1184887 - Tests: add SetARMHwCapFlags as a testing builtin and use it in testAtomics

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: setarmhwcapflags.patch

So, following bug 1183051, I noticed the ARM vfp configuration hasn't been tested on treeherder so far. Let me introduce the setARMHwCapFlags shell builtin function, which does the same as the shell flag, but directly inside the shell, so that we can have it in tests.

I've also fixed indentation in asm.js/testAtomic*, and have had the two tests use asmCompile/asmLink (which actually check that the compilation and linking worked well) instead of plain "use asm" functions. Also added a test case that reproduces the crash in bug 1183051.

Comment 1

[Hannes Verschore [:h4writer]]

Comment on attachment 8635211 [details] [diff] [review]
setarmhwcapflags.patch

Review of attachment 8635211 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/builtin/TestingFunctions.cpp
@@ +2655,5 @@
> +SetARMHwCapFlags(JSContext* cx, unsigned argc, jsval* vp)
> +{
> +    CallArgs args = CallArgsFromVp(argc, vp);
> +
> +#if defined(JS_CODEGEN_ARM)

Can you move this a bit lower. That way we still check the argument count and do the ToString call the same way across platform.

@@ +2664,5 @@
> +
> +    RootedString flagsListString(cx, JS::ToString(cx, args.get(0)));
> +    if (!flagsListString)
> +        return false;
> +

#if defined(JS_CODEGEN_ARM)

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a3b6daa308f2

Comment 3

[Benjamin Bouvier [:bbouvier] (inactive)]

CC'ing Lars, so he's aware of the new function (and of a more proper way to check that an asm.js compilation worked).

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a3b6daa308f2

Comment 5

[Lars T Hansen [:lth]]

Lars notes the change.