1184920 - [Control Center] Lock is a pixel too high compared to the TP icon

Status: VERIFIED FIXED

(Firefox :: General, defect, P1)

Description

[Tim Taubert [:ttaubert] (inactive)]

Ash mentioned on IRC that the lock icon inside the CC is maybe a pixel too high and doesn't align with the headline as the other icons do.

https://i.imgur.com/RZzObpD.png

Comment 1

[Brian Grinstead [:bgrins]]

Attachment: cc-icon-align.png

New screenshot after changes from Bug 1192214.  This is showing that the alignment for the icons / headers is equal between the lock and shield.  Ash, does this look good to you?

Note: depending on the default font the icons and headers may not line up perfectly (as noted in 1192214), but any offset should be consistent between the lock and shield icons and their headers.

Comment 2

[Ash Grigas]

(In reply to Brian Grinstead [:bgrins] from comment #1)
> Created attachment 8648108 [details]
> cc-icon-align.png
> 
> New screenshot after changes from Bug 1192214.  This is showing that the
> alignment for the icons / headers is equal between the lock and shield. 
> Ash, does this look good to you?
> 
> Note: depending on the default font the icons and headers may not line up
> perfectly (as noted in 1192214), but any offset should be consistent between
> the lock and shield icons and their headers.

yes looks good.

Comment 3

[Brian Grinstead [:bgrins]]

Fixed by 1192214

Comment 4

[Paul Silaghi, QA [:pauly]]

(In reply to Brian Grinstead [:bgrins] from comment #3)
> Fixed by 1192214

Comment 5

[Paul Silaghi, QA [:pauly]]

Verified in bug 1192214.