Closed Bug 1184930 Opened 11 years ago Closed 11 years ago

Intermittent browser_888817_currentset_updating.js | Should have updated currentSet after move | Should have updated other window's currentSet after move | Should have updated navbar currentSet after implied remove ...

Categories

(Firefox :: Toolbars and Customization, defect)

Product:
Firefox
Component:
Toolbars and Customization
Platform:
x86
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 42
Tracking Flags:
Tracking Status
e10s + ---
firefox40 --- unaffected
firefox41 --- unaffected
firefox42 --- fixed
firefox-esr31 --- unaffected
firefox-esr38 --- unaffected

People

(Reporter: ryanvm, Assigned: jgriffin)

References

(Blocks 1 open bug)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

test screenshot
676.11 KB, image/png
Details
Attached image test screenshot —
Win7 PGO e10s...
Matt, any chance you can look at this? I would, but I'm trying to tie up loose ends now that I'm off on PTO in the next few hours, and investigating this won't fit into the time I have left before august.
Flags: needinfo?(MattN+bmo)
This is a permafail, lovely.
I'm seeing bug 1179292 in that range, which is making me nervous.
Retriggers confirm that this was tipped into failing by bug 1179292.
Blocks: 1179292
Passing the torch…
Flags: needinfo?(MattN+bmo) → needinfo?(jgriffin)
This occurred after reordering some tests and exposes some test case bug in which a test depends on a previous test. Before the change (when the tests passed), the tests occurred in this order: browser/components/customizableui/test/browser_1003588_no_specials_in_panel.js browser/components/customizableui/test/browser_1007336_lwthemes_in_customize_mode.js browser/components/customizableui/test/browser_1008559_anchor_undo_restore.js browser/components/customizableui/test/browser_1042100_default_placements_update.js browser/components/customizableui/test/browser_1058573_showToolbarsDropdown.js browser/components/customizableui/test/browser_1087303_button_fullscreen.js browser/components/customizableui/test/browser_1087303_button_preferences.js browser/components/customizableui/test/browser_1089591_still_customizable_after_reset.js browser/components/customizableui/test/browser_1096763_seen_widgets_post_reset.js browser/components/customizableui/test/browser_1161838_inserted_new_default_buttons.js browser/components/customizableui/test/browser_873501_handle_specials.js browser/components/customizableui/test/browser_876926_customize_mode_wrapping.js browser/components/customizableui/test/browser_876944_customize_mode_create_destroy.js browser/components/customizableui/test/browser_877006_missing_view.js browser/components/customizableui/test/browser_877178_unregisterArea.js browser/components/customizableui/test/browser_877447_skip_missing_ids.js browser/components/customizableui/test/browser_878452_drag_to_panel.js browser/components/customizableui/test/browser_880164_customization_context_menus.js browser/components/customizableui/test/browser_880382_drag_wide_widgets_in_panel.js browser/components/customizableui/test/browser_884402_customize_from_overflow.js browser/components/customizableui/test/browser_885052_customize_mode_observers_disabed.js browser/components/customizableui/test/browser_885530_showInPrivateBrowsing.js browser/components/customizableui/test/browser_886323_buildArea_removable_nodes.js browser/components/customizableui/test/browser_887438_currentset_shim.js browser/components/customizableui/test/browser_888817_currentset_updating.js Afterwards, this is the order: browser/components/customizableui/test/browser_1003588_no_specials_in_panel.js browser/components/customizableui/test/browser_1007336_lwthemes_in_customize_mode.js browser/components/customizableui/test/browser_1008559_anchor_undo_restore.js browser/components/customizableui/test/browser_1042100_default_placements_update.js browser/components/customizableui/test/browser_1058573_showToolbarsDropdown.js browser/components/customizableui/test/browser_1087303_button_fullscreen.js browser/components/customizableui/test/browser_1087303_button_preferences.js browser/components/customizableui/test/browser_1089591_still_customizable_after_reset.js browser/components/customizableui/test/browser_1096763_seen_widgets_post_reset.js browser/components/customizableui/test/browser_1161838_inserted_new_default_buttons.js browser/components/customizableui/test/browser_888817_currentset_updating.js So, browser_888817_currentset_updating.js probably depends on one of the tests which is executing before it on the "good" run, either because it sets up some condition that persists between tests that this test relies on, or because it cleans up some previous state from an even earlier test. Vaibhav, do we have some way of automatically bisecting to figure out which test is to blame?
Flags: needinfo?(jgriffin) → needinfo?(vaibhavmagarwal)
I haven't checked --bisect-chunk in a long time, and I don't think it works anymore, especially after structured logging changes landed. Anyway, --bisect-chunk did not have the functionality to bisect tests if some previous tests were removed. In this case, since these are browser-chrome tests, so --run-by-dir is active and only the tests in /browser/components/customizableui/test/ are run at a time. I see that in https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=7325fc8acaca the intermittent test is run in mochitest-e10s-bc1 chunk whereas in https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=9b7107f5d99e it is in mochitest-e10s-bc2. I think we will need to manually bisect this one :/
Flags: needinfo?(vaibhavmagarwal)
Hmm, the win32-pgo e10 m-bc runtimes file is missing :( Landing that will likely fix this. Can't run it on try, so will just land.
(In reply to Jonathan Griffin (:jgriffin) from comment #54) > Hmm, the win32-pgo e10 m-bc runtimes file is missing :( Landing that will > likely fix this. Can't run it on try, so will just land. Aha! So we were falling back to chunk-by-dir then instead of run-by-dir?
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #56) > (In reply to Jonathan Griffin (:jgriffin) from comment #54) > > Hmm, the win32-pgo e10 m-bc runtimes file is missing :( Landing that will > > likely fix this. Can't run it on try, so will just land. > > Aha! So we were falling back to chunk-by-dir then instead of run-by-dir? Yes, exactly.
Things are looking promising now that this has merged around and had a chance to cycle. I'll close this out tomorrow if things still look clear.
Flags: needinfo?(ryanvm)
Keywords: leave-open
Winning.
Assignee: nobody → jgriffin
Status: NEW → RESOLVED
Closed: 11 years ago
status-firefox40: --- → unaffected
status-firefox41: --- → unaffected
status-firefox42: affected → fixed
status-firefox-esr31: --- → unaffected
status-firefox-esr38: --- → unaffected
Flags: needinfo?(ryanvm)
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: