Closed Bug 1184942 Opened 9 years ago Closed 9 years ago

[Windows 10] Use (int, rounded down) scaling factor (DPI) to determine height (thickness) of the window top border when drawing in titlebar

Categories

(Core :: Widget: Win32, defect, P2)

defect

Tracking

()

VERIFIED FIXED
mozilla42
Tracking Status
firefox39 --- unaffected
firefox40 --- verified
firefox41 --- verified
firefox42 --- verified

People

(Reporter: Gijs, Assigned: Dolske)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

(In reply to Philipp Sackl [:phlsa] please use needinfo from bug 1173725 comment #95)
> There's still the issue that the top border is slightly thinner when running
> at 200%, but I'll file a follow-up for that.

This is the followup.
Yeah, window border should be 2 physical pixels all the way around, but it's only 1 pixel on top at 200% for me too.
Priority: -- → P2
Attached patch Patch v.1Splinter Review
Trivial fix.

I assume we don't need to worry about scaling factors < 1.0?

Needed to move RoundDown earlier so I could use it, didn't seem to be an obviously good spot for it, better suggestions welcome.
Assignee: nobody → dolske
Attachment #8636411 - Flags: review?(jmathies)
Comment on attachment 8636411 [details] [diff] [review]
Patch v.1

looks good to me.
Attachment #8636411 - Flags: review?(jmathies) → review+
url:        https://hg.mozilla.org/integration/fx-team/rev/f04abbcad33ab553482f5d766fb1e92d58aeac3a
changeset:  f04abbcad33ab553482f5d766fb1e92d58aeac3a
user:       Justin Dolske <dolske@mozilla.com>
date:       Tue Jul 21 11:24:16 2015 -0700
description:
Bug 1184942 - Use DPI scaling factor to ensure top window border is correct thickness. r=jimm
Comment on attachment 8636411 [details] [diff] [review]
Patch v.1

Approval Request Comment
[Feature/regressing bug #]: Windows 10 theme
[User impact if declined]: window border looks wrong at some scale factors
[Describe test coverage new/current, TreeHerder]: n/a
[Risks and why]: low, trivial patch and win10 only.
[String/UUID change made/needed]: n/a
Attachment #8636411 - Flags: approval-mozilla-beta?
Attachment #8636411 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/f04abbcad33a
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Comment on attachment 8636411 [details] [diff] [review]
Patch v.1

Small change that is isolated to Windows 10. Beta+ Aurora+
Attachment #8636411 - Flags: approval-mozilla-beta?
Attachment #8636411 - Flags: approval-mozilla-beta+
Attachment #8636411 - Flags: approval-mozilla-aurora?
Attachment #8636411 - Flags: approval-mozilla-aurora+
Verified on Windows 10 64-bit using:
*latest 42.0a1 Nightly, build ID: 20150810030205,
*latest 41.0a2 Aurora, build ID: 20150810004008,
*Firefox 40 RC, build ID: 20150807085045.
Status: RESOLVED → VERIFIED
QA Contact: cornel.ionce
You need to log in before you can comment on or make changes to this bug.