Closed
Bug 1184947
Opened 9 years ago
Closed 9 years ago
Release Build defaults to BuildChannel.Aurora
Categories
(Firefox for iOS :: Build & Test, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| fxios | + | --- |
People
(Reporter: st3fan, Assigned: sleroux)
Details
Attachments
(1 file)
We need to add a new case to main.swift to use the regular AppDelegate when we are building the Firefox build configuration. Currently it selects the Aurora one which means the Aurora version check and screenshot code is included in production / testflight builds.
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → sleroux
|
|
Assignee | |
Comment 1•9 years ago
|
||
Turns out it wasn't just the codepath that was wrong. The project setting for the release flag was set to Aurora!
Attachment #8635287 -
Flags: review?(sarentz)
|
Reporter | |
Comment 2•9 years ago
|
||
Comment on attachment 8635287 [details] [review] PR https://github.com/mozilla/firefox-ios/pull/764 LGTM
Attachment #8635287 -
Flags: review?(sarentz) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
Merged
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•