1185072 - CSP devtool in GCLI does not show green icon for upgrade-insecure-requests

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Description

[Christoph Kerschbaumer [:ckerschb]]

Since the csp directive upgrade-insecure-reuqests does *not* have any sources and only exists of the directive itself we have to special case it within gcli/commands/security.js

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

Attachment: bug_1185072_glci_upgrade_green_icon.patch

Joe, we recently landed a special CSP directive called upgrade-insecure-requests (Bug 1139297) which is slightly different. Within CSP we usually encounter a directive paired with some srcs. That's different for upgrade-insecure-requests which only consists of a directive name and no srcs. Hence we have to special case that directive within the GCLI devtool. Let me know if you haven any questions.

Comment 2

[Joe Walker [:jwalker]]

Comment on attachment 8639404 [details] [diff] [review]
bug_1185072_glci_upgrade_green_icon.patch

Review of attachment 8639404 [details] [diff] [review]:
-----------------------------------------------------------------

I'm no CSP expert, but I'm happy with this change from a GCLI point of view, and as far as I can tell the code does what the bug alleges it should.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/82f4acb95b50

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/82f4acb95b50