1185083 - Empty panel, Remote Tabs displays errant cell dividing line

Status: RESOLVED FIXED

(Firefox for iOS :: Home screen, defect)

Description

[Robin Andersen [:tecgirl]]

Attachment: iOS Simulator Screen Shot Jul 17, 2015, 1.12.33 PM.png

In landscape, a cell divider appears at the bottom of the Remote Tabs panel (below the content). It should not appear.

See attached.

Comment 1

[Bryan Munar (:bkmunar)]

Attachment: PR

Comment 2

[Brian Nicholson (:bnicholson)]

Comment on attachment 8635606 [details] [review]
PR

Not a huge fan of this fix...the "3 * cell.bounds.width" value being used feels completely arbitrary. Also, I noticed that I still see a small bit of the separator in the bottom right corner when I test on the iPad Air profile.

I'm not familiar these iOS UI hacks -- sleroux might have some ideas.

Comment 3

[Stephan Leroux [:sleroux]]

Comment on attachment 8635606 [details] [review]
PR

There's actually a neat trick you can do to get rid of this line instead of setting a large inset. UITableViews by default will always show the separators unless there is a footer specified. If there is a footer, the bottom line won't appear. To fix this, I usually just set a footer for the first section and set it to a basic UIView.

Comment 4

[Stephan Leroux [:sleroux]]

Comment on attachment 8635606 [details] [review]
PR

Looks good!