Closed Bug 1185110 Opened 10 years ago Closed 10 years ago

Shorten the IDs for the quick filter field

Categories

(Tree Management :: Treeherder, defect, P5)

Product:
Tree Management
Component:
Treeherder
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: jfrench, Assigned: scriptofer, Mentored)

References

(
URL
)

Details

(Whiteboard: [good first bug][lang=css])

User Story

Thank you for helping out with Treeherder!

You can find us on IRC at irc://irc.mozilla.org/treeherder

Here's some links to help get you started.

Project page:
https://wiki.mozilla.org/Auto-tools/Projects/Treeherder

Interacting with us, repo locations and links to set up a development version of the software:
https://wiki.mozilla.org/Auto-tools/Projects/Treeherder#Contributing
https://wiki.mozilla.org/Auto-tools/Projects/Treeherder#Source_and_Docs

A-Team general reference, coding style guides:
https://ateam-bootcamp.readthedocs.org

Attachments

(1 file, 1 obsolete file)

PR-807
46 bytes, text/x-github-pull-request
jfrench
: review+
Details | Review
Per the thread in https://github.com/mozilla/treeherder/pull/617/files We might like to shorten the length of the search filter IDs, and I pose going forward we refer to the upper right hand filter UI as the 'quick filter' from a customer facing side anyway. It helps differentiate it from the global filter panel. So, changing occurrences of: platform-job-text-search-field-(things) To: quick-filter-(things) For a contributor to do this they need to setup treeherder locally, change those occurrences in treeherder's html and css, test the changes, and open a Github pull request to iterate in the review.
Mentor: tojonmz
Whiteboard: [good first bug][lang=js] → [good first bug][lang=css]
Scriptofer would like to do this one, so assigning. Thanks Scriptofer!
Assignee: nobody → scriptofer
Status: NEW → ASSIGNED
Attachment #8636570 - Attachment description: Added all the changes as per the review comments. → PR to shorten the IDs. Integrated all review comments.
Attachment #8636570 - Attachment filename: file_1185110.txt → PR789.txt
Attachment #8636570 - Flags: review?(tojonmz)
Thanks! Having a look again now.
Comment on attachment 8636570 [details] [review] PR to shorten the IDs. Integrated all review comments. Looks good to me now in Github, and in local testing on Nightly and Chrome. :scriptofer you will just need to squash locally to combine all your commits into a single commit. Then after that, a `git rebase -i` over latest master so the change is based off the latest state of the repo. Then re-push to your remote, and we can merge :)
Attachment #8636570 - Flags: review?(tojonmz) → review+
I noticed you were not in channel, but you can check my comments from today re: a local repo backup prior to your squash and/or rebase for the first time. http://logs.glob.uno/?c=mozilla%23treeherder&s=21+Jul+2015&e=21+Jul+2015
Attached file PR-807 —
Attachment #8638531 - Flags: review?(tojonmz)
I have submitted new PR. i done something wrong while git rebase. I will make new branch henceforth for new feature. jfrench: Please review this new pull request.
Comment on attachment 8636570 [details] [review] PR to shorten the IDs. Integrated all review comments. Marking the original PR obsolete. Feel free to do this scriptofer when adding an attachment that obsoletes an earlier one (eg. images, error logs, etc).
Attachment #8636570 - Attachment is obsolete: true
Comment on attachment 8638531 [details] [review] PR-807 This looks good to me, I happened to have a local branch with the original closed/unmerged PR https://github.com/mozilla/treeherder/pull/789 that got force pushed on Github. So I dumped my diff from that branch locally, and dumped the diff from this PR in another local branch, and diff'd them against each other to ensure they were identical. I also re-tested this new PR locally and it looks correct. So I will merge shortly.
Attachment #8638531 - Flags: review?(tojonmz) → review+
Commits pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/e5ce9b8c1bd14eddd0eaa7c0639c08ec5f187e0f Bug 1185110 - Shorten the IDs for the quick filter field https://github.com/mozilla/treeherder/commit/7744099ea2b4b54f346f7a5cf114e387ab21f60b Merge pull request #807 from scriptofer/Bug-1185110 Bug 1185110 - Shorten the IDs for the quick filter field
Marking fixed per above merge, thank you scriptofer! This can be tested and verified shortly on stage.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: