1185148 - New test chooser doesn't work if there are two signatures with the same name

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect)

Description

[William Lachance (:wlach)]

How to reproduce:

* Go to https://treeherder.mozilla.org/perf.html#/graphs?timerange=5184000 (60 day timerange)
* Open test chooser
* Note lack of tests to choose

The problem is that on Android (our default platform) there is more than one signature that resolves to "tp4m summary". We should track these elements by signature, not name so that isn't a problem (if we really wanted to be pedantic, we would also put a (N) next to elements which are duplicates, but I think we can avoid doing that for a first pass as this case is quite uncommon)

I have a patch in progress for this, I'll finish it off next week.

Comment 1

[William Lachance (:wlach)]

Attachment: Fix various problems in test chooser

So this fixes the original problem (signature list is blank in test chooser in some cases) and also cleans up the code and fixes some other minor issues.

I probably should have done a more thorough review/test of MikeLing's original code, sorry about that. MikeLing: please have a look at this patch if you have time. You could consider the changes some additional comments on your original work (which was 99% of the way there, there were just some minor problems).

Comment 2

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/a764ce05ffb17e2c3981107dcd51e59a1f2c3ae6
Bug 1185148 - Fix various problems in perfherder test chooser

* Chooser is now ok with two tests with same name (but different signatures)
* If test is already added to graph (or has already been selected), don't
  allow user to choose it again
* Improved variable names and general simplification of code

Comment 3

[William Lachance (:wlach)]

Resolving this. MikeLing: Feel free to still give feedback. :)

Comment 4

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/655f06b136ddd50cea180b90c9f316bb9b2d67d6
Bug 1185148 - Fix problem loading graphs UI from persisted URL