Closed Bug 1185165 Opened 9 years ago Closed 1 month ago

Add-on ID validation doesn't match Firefox Add-on Manager

Categories

(addons.mozilla.org Graveyard :: Add-on Validation, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: jorgev, Unassigned)

Details

The Add-on Manager uses the following regular expression for add-on IDs:

/^(\{[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}\}|[a-z0-9-\._]*\@[a-z0-9-\._]+)$/

(from http://hg.mozilla.org/mozilla-central/file/911935404233/toolkit/mozapps/extensions/internal/XPIProvider.jsm#l237)

Notably, it doesn't accept the '+' character. AMO does, which leads to AMO accepting extensions that can't be installed into Firefox (a corrupt file error is shown when you try to install them).

The validator should show an error if the add-on ID doesn't match the regular expression used in Firefox.
Huh. Interesting. It seems that bug 1047868 got fixed even though I commented and marked it as invalid.
Assignee: nobody → kmaglione+bmo
Status: NEW → ASSIGNED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
Assignee: kmaglione+bmo → nobody
Status: ASSIGNED → NEW
Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.