observePreferences method is unused

RESOLVED WONTFIX

Status

()

RESOLVED WONTFIX
3 years ago
3 years ago

People

(Reporter: Margaret, Unassigned, Mentored)

Tracking

35 Branch
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [lang=js][good first bug])

(Reporter)

Description

3 years ago
To start, set up a build environment - you can see the instructions here: https://wiki.mozilla.org/Mobile/Fennec/Android

Then, you'll need to create a patch to upload - see
https://wiki.mozilla.org/Mobile/Fennec/Android#Creating_commits_and_submitting_patches

To fix this bug, you need to remove this method:
http://hg.mozilla.org/mozilla-central/annotate/911935404233/mobile/android/chrome/content/browser.js#l2130

For bonus points, it looks like we can also refactor this code to remove the `handlePreferencesRequest` method by putting its body inside `getPreferences`, since that will be its only consumer.

If you need any help, you can reply to this bug, or feel free to message me on IRC - my nick is "margaret" and you can find me in #mobile. If you need IRC setup instructions, see https://wiki.mozilla.org/IRC

Thanks and happy coding! ^_^
Actually, observePreferences *is* called as part of the nsIAndroidBridge system. Adding in bug 906088.
(Reporter)

Comment 2

3 years ago
My bad, I must have done a bad job looking into that!
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.