1185202 - solaris and libstagefright

Status: RESOLVED WONTFIX

(Firefox Build System :: General, defect)

Description

[Richard PALO]

Attachment: solaris-byteswap.h

User Agent: Mozilla/5.0 (X11; SunOS i86pc; rv:31.0) Gecko/20100101 Firefox/31.0
Build ID: 20150715204604

Steps to reproduce:

initial missing includes for solaris



Expected results:

--- media/libstagefright/moz.build.orig	2015-06-24 21:27:56.000000000 +0000
+++ media/libstagefright/moz.build
@@ -7,7 +7,7 @@
 DEFINES['ANDROID_SMP'] = 0
 DEFINES['LOG_NDEBUG'] = 1
 
-if CONFIG['OS_TARGET'] != 'WINNT':
+if CONFIG['OS_TARGET'] != 'WINNT' and CONFIG['OS_ARCH'] != 'SunOS':
    DEFINES['_GLIBCXX_OS_DEFINES'] = True
 
 if CONFIG['OS_TARGET'] == 'WINNT':
@@ -33,6 +33,9 @@ elif CONFIG['OS_TARGET'] in ('DragonFly'
     if CONFIG['OS_TARGET'] != 'GNU/kFreeBSD':
         DEFINES['off64_t'] = 'off_t'
         LOCAL_INCLUDES += [ 'ports/bsd/include' ]
+elif CONFIG['OS_ARCH'] == 'SunOS':
+    DEFINES['HAVE_SYS_UIO_H'] = True
+    LOCAL_INCLUDES += [ 'ports/solaris/include' ]
 else:
     DEFINES['HAVE_SYS_UIO_H'] = True

Comment 1

[Richard PALO]

I forgot to mention that defining _GLIBCXX_OS_DEFINES can cause innumerable problems involving
the absence of the following being fixed up via os_defines.h:

#if __cplusplus >= 199711L
#define __CORRECT_ISO_CPP_MATH_H_PROTO
#define __CORRECT_ISO_CPP_STDLIB_H_PROTO
#define __CORRECT_ISO_CPP_STRING_H_PROTO
#define __CORRECT_ISO_CPP_WCHAR_H_PROTO
#endif

Comment 2

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Superseded by bug 1408298 which removed stagefright.