1185260 - Remove manual package manifest preprocessing in Thunderbird

Status: RESOLVED WORKSFORME

(Thunderbird :: Build Config, defect)

Description

[Philip Chee]

+++ This bug was initially created as a clone of Bug #1184446 +++

(From Bug 1184446 comment #1)
> Created attachment 8634585 [details] [diff] [review] [diff] [review]
> Remove manual package manifest preprocessing
> 
> packager.py itself has been able to do preprocessing since the beginning.
> For some reason, Makefile.in-driven preprocessing was kept back then, and
> never was removed, and even worse, concatenation was added on top of it.
> 
> There is however a downside to the current way of doing things: error
> reporting is given relative to the given manifest, which in the current
> case is the preprocessed/concatenated file, so line numbers don't match
> what is in the file in the source tree. However, when packager.py does
> preprocessing itself, line numbers are reported properly.
> 
> Thus, switch all package manifests to packager.py-driven preprocessing.
> 
> I validated that this doesn't change the list of files in the resulting
> firefox builds on try.

Comment 1

[Rob Lemley [:rjl]]

It looks like the changes from bug 1184446 have found their way into the Thunderbird packaging code now.