1185324 - Duplicate MIME type entries can be shown if multiple libraries are pointing to a plugin

Status: RESOLVED WONTFIX

(Core Graveyard :: Plug-ins, defect)

Description

[sworddragon2]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:39.0) Gecko/20100101 Firefox/39.0
Build ID: 20150629110007

Steps to reproduce:

1. Install 2 libraries for a plugin (in my case a 64 bit Flash Player and the 32 bit debug version of it (with nspluginwrapper)).
2. Go to the menu bar -> Tools -> Add-ons -> Plugins and click "More" of the specific plugin.


Actual results:

For example in my case the MIME types are shown 2 times.


Expected results:

Duplicate MIME types should not be shown.

Comment 1

[u554753]

Hi sworddragon2, 

Try updating to Firefox 42, are you still having the issue on the newest build? Thanks.

Comment 2

[Georg Fritzsche [:gfritzsche]]

This is still an issue.

The affected code is here:
https://dxr.mozilla.org/mozilla-central/rev/2bdd9ec79799eff3ceec0a318f5a0632d918a527/toolkit/mozapps/extensions/internal/PluginProvider.jsm#459

The problem is that we collect all of the mimetypes into the array |types|, without filtering out duplicates.
We should use a Set [0] here and |return [...types]| from this function.

We need to do some manual testing of this to check it is working.

0: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Set

Comment 3

[Andrew McCreight [:mccr8]]

gfritzsche has not been involved with Mozilla for more than a year so will unfortunately no longer be a suitable mentor.

Comment 4

[BMO Automation]

Resolving as wont fix, plugin support deprecated in Firefox 85.