Closed Bug 1185360 Opened 4 years ago Closed 4 years ago

PostMessageEvent should not have a different behavior if the main principal subsumes the destination one.

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: baku, Assigned: baku)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch subsumes.patch (obsolete) — Splinter Review
No description provided.
Attachment #8635796 - Flags: review?(bugs)
Summary: PostMessageEvent should not have a different behavior if the original principal subsumes the destination one. → PostMessageEvent should not have a different behavior if the main principal subsumes the destination one.
Attached patch subsumes.patchSplinter Review
Attachment #8635796 - Attachment is obsolete: true
Attachment #8635796 - Flags: review?(bugs)
Attachment #8635807 - Flags: review?(bugs)
Blocks: 1184557
Blocks: 722126
Depends on: 673742
Comment on attachment 8635807 [details] [diff] [review]
subsumes.patch

We need some tests here - and as far as I see, this doesn't work.
We end up using the same FileList object on both sides, but we should clone.
And that would just cause security exception to be thrown on the receiving side since it can't access the wrapper from the sending side if those are cross-origin.
Attachment #8635807 - Flags: review?(bugs) → review-
> We need some tests here - and as far as I see, this doesn't work.
> We end up using the same FileList object on both sides, but we should clone.
> And that would just cause security exception to be thrown on the receiving
> side since it can't access the wrapper from the sending side if those are
> cross-origin.

About FileList, all is fixed in bug 1185381. Here it's just about the subsumes thing.
Which kind of test do you want to see?
Flags: needinfo?(bugs)
That we actually get a clone when passing FileList, and also the contained Files should be cloned.
Flags: needinfo?(bugs)
I added the test in bug 1185360. Can you take a look at this patch again when you have time? Thanks
Flags: needinfo?(bugs)
Comment on attachment 8635807 [details] [diff] [review]
subsumes.patch

Ok, so this must not land before the patch which makes FileList cloning work properly, but at the same time.
Flags: needinfo?(bugs)
Attachment #8635807 - Flags: review- → review+
https://hg.mozilla.org/mozilla-central/rev/a9af8583cd34
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Duplicate of this bug: 722126
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.