PostMessageEvent should not have a different behavior if the main principal subsumes the destination one.

RESOLVED FIXED in Firefox 42

Status

()

Core
DOM
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: baku, Assigned: baku)

Tracking

Trunk
mozilla42
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
Created attachment 8635796 [details] [diff] [review]
subsumes.patch
Attachment #8635796 - Flags: review?(bugs)
(Assignee)

Updated

3 years ago
Summary: PostMessageEvent should not have a different behavior if the original principal subsumes the destination one. → PostMessageEvent should not have a different behavior if the main principal subsumes the destination one.
(Assignee)

Comment 1

3 years ago
Created attachment 8635807 [details] [diff] [review]
subsumes.patch
Attachment #8635796 - Attachment is obsolete: true
Attachment #8635796 - Flags: review?(bugs)
Attachment #8635807 - Flags: review?(bugs)
(Assignee)

Updated

3 years ago
Blocks: 1184557

Updated

3 years ago
Blocks: 722126

Updated

3 years ago
Depends on: 673742

Comment 2

3 years ago
Comment on attachment 8635807 [details] [diff] [review]
subsumes.patch

We need some tests here - and as far as I see, this doesn't work.
We end up using the same FileList object on both sides, but we should clone.
And that would just cause security exception to be thrown on the receiving side since it can't access the wrapper from the sending side if those are cross-origin.
Attachment #8635807 - Flags: review?(bugs) → review-
(Assignee)

Comment 3

3 years ago
> We need some tests here - and as far as I see, this doesn't work.
> We end up using the same FileList object on both sides, but we should clone.
> And that would just cause security exception to be thrown on the receiving
> side since it can't access the wrapper from the sending side if those are
> cross-origin.

About FileList, all is fixed in bug 1185381. Here it's just about the subsumes thing.
Which kind of test do you want to see?
Flags: needinfo?(bugs)

Comment 4

3 years ago
That we actually get a clone when passing FileList, and also the contained Files should be cloned.
Flags: needinfo?(bugs)
(Assignee)

Comment 5

3 years ago
I added the test in bug 1185360. Can you take a look at this patch again when you have time? Thanks
Flags: needinfo?(bugs)

Comment 6

3 years ago
Comment on attachment 8635807 [details] [diff] [review]
subsumes.patch

Ok, so this must not land before the patch which makes FileList cloning work properly, but at the same time.
Flags: needinfo?(bugs)
Attachment #8635807 - Flags: review- → review+
https://hg.mozilla.org/mozilla-central/rev/a9af8583cd34
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox42: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
(Assignee)

Updated

3 years ago
Duplicate of this bug: 722126
You need to log in before you can comment on or make changes to this bug.