1185399 - Replace macros in pldhash.{cpp.h}

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Nicholas Nethercote [inactive]]

Yet another step in transforming PLDHashTable away from crust old C code: get rid of the macros.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: (part 1) - Remove macros from pldhash.h

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: (part 2) - Remove macros from pldhash.cpp

Comment 3

[Nathan Froyd [:froydnj]]

Comment on attachment 8635885 [details] [diff] [review]
(part 2) - Remove macros from pldhash.cpp

Review of attachment 8635885 [details] [diff] [review]:
-----------------------------------------------------------------

::: xpcom/glue/pldhash.cpp
@@ +334,5 @@
> +/* Compute the address of the indexed entry in table. */
> +PLDHashEntryHdr*
> +PLDHashTable::AddressEntry(uint32_t aIndex)
> +{
> +  return reinterpret_cast<PLDHashEntryHdr*>(mEntryStore + aIndex * mEntrySize);

Wonder if it'd be worth MOZ_ASSERT'ing that aIndex is within bounds.  Not sure how much that would slow things down...

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3bbc89c5395c
https://hg.mozilla.org/integration/mozilla-inbound/rev/c642708766fd

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3bbc89c5395c
https://hg.mozilla.org/mozilla-central/rev/c642708766fd