Please whitelist the "AsyncPluginShutdown" and "AsyncPluginShutdownStates" annotations

RESOLVED FIXED

Status

Socorro
General
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: gerald, Assigned: adrian)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

2 years ago
Bug 1183433 added the "AsyncPluginShutdownStates" annotation, which is a string, to help us track some GeckoMediaPlugin shutdown-hang issues (e.g., bug 1183972).
(Reporter)

Comment 1

2 years ago
Adrian, I see you took care of a previous whitelisting (bug 1155511), could you please have a look at this one? (Or assign to someone else as appropriate)

"AsyncPluginShutdown" was added in bug 1173634.
"AsyncPluginShutdownStates" was added in bug 1183433.
Both contain strings.
Flags: needinfo?(adrian)
(Assignee)

Comment 2

2 years ago
Will do asap! I might need bug 1175946 first, not sure yet.
Assignee: nobody → adrian
Depends on: 1175946
Flags: needinfo?(adrian)
(Assignee)

Updated

2 years ago
Depends on: 1186945
(Assignee)

Comment 3

2 years ago
There seems to be a problem with the `AsyncPluginShutdown` field, I do not see it in our data but I can see a few fields with this sort of names: "raw_crash.AsyncPluginShutdown-Primetime Content Decryption Module provided by Adobe Systems, Incorporated@1663cc00". The last few chars can vary. 

I am unsure what to do here, it seems to me that the name of this field in incorrect and should be fixed before I can add that to our whitelist.
(Reporter)

Comment 4

2 years ago
(In reply to Adrian Gaudebert [:adrian] from comment #3)
> There seems to be a problem with the `AsyncPluginShutdown` field, I do not
> see it in our data

Do you mean only with `AsyncPluginShutdown`, but you can see `AsyncPluginShutdownStates`? If that's the case, please whitelist `AsyncPluginShutdownStates`, it's the most important of the two and would be very useful to have.

> but I can see a few fields with this sort of names:
> "raw_crash.AsyncPluginShutdown-Primetime Content Decryption Module provided
> by Adobe Systems, Incorporated@1663cc00". The last few chars can vary. 

This always-changing annotation was a mistake that made it through to Aurora, and was removed soon after (see bug 1183433), so hopefully there won't be too many of these.

> I am unsure what to do here, it seems to me that the name of this field in
> incorrect and should be fixed before I can add that to our whitelist.

I've just forced a shutdown-hang crash in Nightly 42.0a1 (2015-08-02) by following the steps in bug 1175364:
https://crash-stats.mozilla.com/report/index/3e6954df-f7c0-4f56-8e7b-58a532150803
The report should contain at least `AsyncPluginShutdownStates` (I don't have dmp access so I cannot verify that; but I did see it in the UI when submitting the report).
I didn't see `AsyncPluginShutdown`, there are circumstances where it's possible it would not be created, or would be removed; And it's less important now anyway, as `AsyncPluginShutdownStates` gives much more useful information.

Here's one in 41.0a2 (2015-08-02), with `AsyncPluginShutdownStates` as well:
https://crash-stats.mozilla.com/report/index/1b7fd243-feae-41bb-b9d1-019c02150803

It's possible that these annotations haven't been seen in the wild yet, as it's quite rare (hence the need for annotations) and the annotation code has only recently been uplifted to 41 and 40.
My best hope to catch it would be in crash reports with this signature:
https://crash-stats.mozilla.com/signature/?signature=shutdownhang+|+WaitForSingleObjectEx+|+WaitForSingleObject+|+PR_Wait+|+nsThread%3A%3AProcessNextEvent%28bool%2C+bool*%29+|+NS_ProcessNextEvent%28nsIThread*%2C+bool%29+|+mozilla%3A%3Agmp%3A%3AGeckoMediaPluginServiceParent%3A%3AObserve%28nsISupports*%2C+char+const*%2C+wchar_t+const*%29

So with my forced crash above, would you be able to at least whitelist `AsyncPluginShutdownStates` please?
Flags: needinfo?(adrian)
(Assignee)

Comment 5

2 years ago
Sorry I wasn't clear indeed. In Socorro, we have an admin page that shows us all the different field names that appeared at least once across all our documents in the last month. So I took a look at that list to see if `AsyncPluginShutdown` was there, and it wasn't. And now I'm looking into our production data, and I can find it, so I feel stupid... :) Anyway, the other problem that I see is that there are a lot of fields named like this: 

AsyncPluginShutdown-Primetime Content Decryption Module provided by Adobe Systems, Incorporated@1063fc00

Along with the expected `AsyncPluginShutdown` and `AsyncPluginShutdownStates`. On stage I could only find `AsyncPluginShutdownStates` and the weirdly looking fields, but not `AsyncPluginShutdown` so I got confused. 

So I guess all is fine. I'll go ahead and add those fields on stage and prod.
Flags: needinfo?(adrian)
(Reporter)

Comment 6

2 years ago
Adrian, have you had a chance to whitelist `AsyncPluginShutdown` and `AsyncPluginShutdownStates`?

I cannot see them in some reports I've looked at (e.g., [1]), but I'm not sure whether they are actually in those reports -- Should they be visible in the 'metadata' page?)

Note that `AsyncPluginShutdown` may actually not appear in any/all reports, if the crash happens before it is first created or after it is removed.
However `AsyncPluginShutdownStates` should theoretically be present in most shutdown-hang crash reports involving GeckoMediaPlugins.

[1] https://crash-stats.mozilla.com/report/index/00dbe19f-2472-425e-84e1-ffd1d2150819#metadata
Flags: needinfo?(adrian)
(Reporter)

Comment 7

2 years ago
Not as urgent anymore.
Flags: needinfo?(adrian)
(Assignee)

Comment 8

2 years ago
Both fields have been added, as `async_plugin_shutdown` and `async_plugin_shutdown_states`. They will start working next week, when we create a new index in our Elasticsearch database. 

For example: https://crash-stats.mozilla.com/search/?product=Firefox&_facets=async_plugin_shutdown&_facets=async_plugin_shutdown_states
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.