Closed Bug 1185416 Opened 4 years ago Closed 4 years ago

Don't stop AudioSink prematurely when decoding is completed

Categories

(Core :: Audio/Video, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(1 file)

This bug addresses bug 1184742 comment 0.
This is what happened:

1. we skip the if block for mPlayState is not playing at [1]
2. StopAudioThread() is called
3. mPlayState becomes playing and we enter the if block.
4. We hit the assertion at [2] for mAudioSink is null and mAudioCompleted is true.


[1] https://hg.mozilla.org/integration/mozilla-inbound/annotate/accaecdd989d/dom/media/MediaDecoderStateMachine.cpp#l2420
[2] https://hg.mozilla.org/integration/mozilla-inbound/annotate/accaecdd989d/dom/media/MediaDecoderStateMachine.cpp#l3083
Blocks: 1184742
Only stop audio sink when we really finish playback.
Assignee: nobody → jwwang
Status: NEW → ASSIGNED
Attachment #8636916 - Flags: review?(kinetik)
Attachment #8636916 - Flags: review?(kinetik) → review+
Thanks for the review.
https://hg.mozilla.org/mozilla-central/rev/934dcc90d4ac
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.