1185416 - Don't stop AudioSink prematurely when decoding is completed

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

This bug addresses bug 1184742 comment 0.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

This is what happened:

1. we skip the if block for mPlayState is not playing at [1]
2. StopAudioThread() is called
3. mPlayState becomes playing and we enter the if block.
4. We hit the assertion at [2] for mAudioSink is null and mAudioCompleted is true.


[1] https://hg.mozilla.org/integration/mozilla-inbound/annotate/accaecdd989d/dom/media/MediaDecoderStateMachine.cpp#l2420
[2] https://hg.mozilla.org/integration/mozilla-inbound/annotate/accaecdd989d/dom/media/MediaDecoderStateMachine.cpp#l3083

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=117dd7af3047

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: 1185416_dont_stop_audiosink_prematurely-v1.patch

Only stop audio sink when we really finish playback.

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/934dcc90d4ac

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/934dcc90d4ac