1185433 - Hide inactive and unlisted add-ons from search results

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Kris Maglione [:kmag]]

As of this commit[1], we no longer index add-ons once the `disabled_by_user` is turned on or `is_listed` is turned off. Which means that if the add-ons are already in the index, those flags do not get updated in ES, and the add-ons remain in search results, but link to disabled listing pages.

We need to go back to updating those entries, and reindex add-ons with these flags (the reindex cron job is no longer enabled) so that they stop showing up in search results.

[1] https://github.com/mozilla/olympia/commit/ae2e2cb

Comment 1

[Kris Maglione [:kmag]]

https://github.com/mozilla/olympia/pull/611

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/olympia

https://github.com/mozilla/olympia/commit/e0defebb4c631c2f92ae3a749f2258ad7afecba0
Bug 1185433: Hide unlisted and disabled add-ons from search results.

https://github.com/mozilla/olympia/commit/c5dc925149a77a4b60d73c1d52c4064d1155710c
Merge pull request #611 from kmaglione/bug-1185433

Bug 1185433: Hide unlisted and disabled add-ons from search results.

Comment 3

[Valentina Virlics [:vvalentina], VPN QA]

Verified on AMO-dev FF40(Win 7) and I receive this result: http://screencast.com/t/sTvjzj5s5mL3
Verified on AMO-stage FF40(Win 7) and I receive this result: http://screencast.com/t/KXrbwjwmNR

Which is the correct result?

Comment 4

[Kris Maglione [:kmag]]

The behavior on dev is the correct result. How long have the add-ons been disabled?

Comment 5

[Valentina Virlics [:vvalentina], VPN QA]

Both addons where disabled few moments before testing the search.
I've tested on AMO-stage FF40(Win 7) again now, the same addon that was disabled yesterday, and it is no longer listed between search results.

I've disabled another addon and the changes where taken instantly. (i.e. Addon15.07-álás!;)

I have another question... in the explanations near "Hidden" option, it says "... but hidden to anyone but authors" does this also refers to searching results? because I've searched my addon, after disabling it and I could not find it..
Thanks!

Comment 6

[Valentina Virlics [:vvalentina], VPN QA]

After asking on irc channel, I received the answer for hidden addons, hidden addons should not be displayed in search results, also. 

Verified as fixed on AMO-dev FF40(Win 7).
Postfix screencast: http://screencast.com/t/94gunCQhBVhx
Closing bug.