1185454 - Fix eslint issue revealed in eslint 0.24.1 and upgrade eslint-plugin-react to 2.7.1

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect)

Description

[Mark Banner (:standard8)]

Here's the release notes:

http://eslint.org/blog/2015/07/eslint-0.24.1-released/
https://github.com/yannickcr/eslint-plugin-react/releases

The 0.24.1 release picks up an additional comma-dangle issue.

eslint-plugin-react has a couple of new rules, but I don't think we want to use either of them (at least in their current form). The upgrade for the plugin though does add support for the eslint 1.0.0 code, which helps with testing the rc releases.

Comment 1

[Mark Banner (:standard8)]

Attachment: Fix eslint issue for Loop revealed in eslint 0.24.1, and upgrade the react plugin for eslint version to 2.7.1

Simple patch to do the upgrades.

Comment 2

[Mike de Boer [:mikedeboer]]

Comment on attachment 8635950 [details] [diff] [review]
Fix eslint issue for Loop revealed in eslint 0.24.1, and upgrade the react plugin for eslint version to 2.7.1

Review of attachment 8635950 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/loop/.eslintrc
@@ +76,5 @@
>      "react/no-unknown-property": 2,
>      "react/prop-types": 2,
>      "react/self-closing-comp": 2,
>      "react/wrap-multilines": 2,
> +    // We would probably want to go with a variant of never

nit: missing dot.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/388d01dba6c3

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/388d01dba6c3