Closed Bug 1185489 Opened 9 years ago Closed 1 year ago

Intermittent Assertion failure: refCnt > 0, at /builds/worker/workspace/build/src/modules/libjar/nsZipArchive.cpp:133

Categories

(Core :: Security: PSM, defect, P3)

defect

Tracking

()

RESOLVED INCOMPLETE

People

(Reporter: cbook, Unassigned)

References

()

Details

(4 keywords, Whiteboard: [psm-intermittent])

Attachments

(1 file)

https://treeherder.mozilla.org/logviewer.html#?job_id=11892960&repo=mozilla-inbound

03:05:00 WARNING - PROCESS-CRASH | toolkit/mozapps/extensions/test/browser/browser_updatessl.js | application crashed [@ nsZipArchive::~nsZipArchive()]
03:05:00 INFO - Crash dump filename: /tmp/tmp3XgpR2.mozrunner/minidumps/064b20be-c266-69e4-7d848481-29b9c838.dmp
03:05:00 INFO - Operating system: Linux
03:05:00 INFO - 0.0.0 Linux 3.2.0-76-generic #111-Ubuntu SMP Tue Jan 13 22:16:09 UTC 2015 x86_64
03:05:00 INFO - CPU: amd64
03:05:00 INFO - family 6 model 45 stepping 7
03:05:00 INFO - 1 CPU
03:05:00 INFO - Crash reason: SIGSEGV
03:05:00 INFO - Crash address: 0x0
03:05:00 INFO - Thread 0 (crashed)
03:05:00 INFO - 0 libxul.so!nsZipArchive::~nsZipArchive() [nsZipArchive.cpp:7e15449cb6e8 : 134 + 0x22]
03:05:00 INFO - rbx = 0x00007f57cada8000 r12 = 0x0000000000000000
03:05:00 INFO - r13 = 0x0000000000000000 r14 = 0x0000000000000000
03:05:00 INFO - r15 = 0x00007fff1544f918 rip = 0x00007f57d3d334ab
03:05:00 INFO - rsp = 0x00007fff1544f750 rbp = 0x00007fff1544f760
03:05:00 INFO - Found by: given as instruction pointer in context
03:05:00 INFO - 1 libxul.so!nsZipArchive::Release() [nsZipArchive.cpp:7e15449cb6e8 : 883 + 0x7]
03:05:00 INFO - rbx = 0x00007f57cada8000 r12 = 0x0000000000000000
03:05:00 INFO - r13 = 0x0000000000000000 r14 = 0x0000000000000000
03:05:00 INFO - r15 = 0x00007fff1544f918 rip = 0x00007f57d3d33577
03:05:00 INFO - rsp = 0x00007fff1544f770 rbp = 0x00007fff1544f780
03:05:00 INFO - Found by: call frame info
03:05:00 INFO - 2 libxul.so!mozilla::Omnijar::CleanUpOne(mozilla::Omnijar::Type) [Omnijar.cpp:7e15449cb6e8 : 34 + 0x4]
03:05:00 INFO - rbx = 0x0000000000000001 r12 = 0x00007f57d875ed20
03:05:00 INFO - r13 = 0x0000000000000000 r14 = 0x0000000000000000
03:05:00 INFO - r15 = 0x00007fff1544f918 rip = 0x00007f57d379ce01
03:05:00 INFO - rsp = 0x00007fff1544f790 rbp = 0x00007fff1544f7a0
03:05:00 INFO - Found by: call frame info
03:05:00 INFO - 3 libxul.so!mozilla::Omnijar::CleanUp() [Omnijar.cpp:7e15449cb6e8 : 117 + 0x9]
03:05:00 INFO - rbx = 0x00007f57d9e44b00 r12 = 0x00007f57d375ac24
03:05:00 INFO - r13 = 0x0000000000000000 r14 = 0x0000000000000000
03:05:00 INFO - r15 = 0x00007fff1544f918 rip = 0x00007f57d379ce49
03:05:00 INFO - rsp = 0x00007fff1544f7b0 rbp = 0x00007fff1544f7b0
03:05:00 INFO - Found by: call frame info
03:05:00 INFO - 4 libxul.so!mozilla::ShutdownXPCOM(nsIServiceManager*) [XPCOMInit.cpp:7e15449cb6e8 : 1033 + 0x4]
03:05:00 INFO - rbx = 0x00007f57d9e44b00 r12 = 0x00007f57d375ac24
03:05:00 INFO - r13 = 0x0000000000000000 r14 = 0x0000000000000000
03:05:00 INFO - r15 = 0x00007fff1544f918 rip = 0x00007f57d37a7fdb
03:05:00 INFO - rsp = 0x00007fff1544f7c0 rbp = 0x00007fff1544f800
03:05:00 INFO - Found by: call frame info
03:05:00 INFO - 5 libxul.so!ScopedXPCOMStartup::~ScopedXPCOMStartup() [nsAppRunner.cpp:7e15449cb6e8 : 1498 + 0x7]
03:05:00 INFO - rbx = 0x00007f57d9e78f98 r12 = 0x00007fff1544f928
03:05:00 INFO - r13 = 0x0000000000000000 r14 = 0x0000000000000000
03:05:00 INFO - r15 = 0x00007fff1544f918 rip = 0x00007f57d55c05e8
[Mass Closure] Closing Intermittent as a one off
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WORKSFORME
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Summary: Intermittent browser_updatessl.js | application crashed [@ nsZipArchive::~nsZipArchive()] → Intermittent browser_updatessl.js,test_system_update.js | application crashed [@ nsZipArchive::~nsZipArchive()]
Component: General → Networking: JAR
Summary: Intermittent browser_updatessl.js,test_system_update.js | application crashed [@ nsZipArchive::~nsZipArchive()] → Intermittent browser_updatessl.js,test_system_update.js,browser_username_select_dialog.js | application crashed [@ nsZipArchive::~nsZipArchive()] after Assertion failure: refCnt > 0, at nsZipArchive.cpp:135
Patrick, do you think this could be caused by Bug 1215319.
The start date of the failures seems to match that of the push.
Flags: needinfo?(mcmanus)
(In reply to Valentin Gosu [:valentin] from comment #5)
> Patrick, do you think this could be caused by Bug 1215319.
> The start date of the failures seems to match that of the push.

I don't think so.

1] the bug is complaining about the reference count, and the changes in the bug were really just bounds checks

2] if you look at the complete history of that orange https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1185489&entireHistory=true&tree=all you'll see a number of pre-existing instances (before that change)

https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=26018589#L1393
https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=27536464#L2699
https://treeherder.mozilla.org/logviewer.html#?repo=fx-team&job_id=9220712#L2758

they look just like the instances after that.. e.g.
https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=30074657#L17138
Flags: needinfo?(mcmanus)
MozReview-Commit-ID: 3FB354GXVex
Attachment #8762681 - Flags: review?(mcmanus)
Assignee: nobody → valentin.gosu
Status: REOPENED → ASSIGNED
Whiteboard: [necko-active]
Comment on attachment 8762681 [details] [diff] [review]
Turn ZipArchiveLogger::refCnt from int to ThreadSafeAutoRefCnt

Review of attachment 8762681 [details] [diff] [review]:
-----------------------------------------------------------------

* This module implements a simple archive extractor for the PKZIP format.
 *
 * The underlying nsZipArchive is NOT thread-safe. Do not pass references
 * or pointers to it across thread boundaries.

we could assert is main thread in the ref counting functions to test your theory and find the violator. would be good to have in any event

the other possibility is that ominjar is just releasing it twice somehow.. have you looked at that? (I haven't).
Attachment #8762681 - Flags: review?(mcmanus) → review-
(In reply to Patrick McManus [:mcmanus] from comment #8)
> Comment on attachment 8762681 [details] [diff] [review]
> Turn ZipArchiveLogger::refCnt from int to ThreadSafeAutoRefCnt
> 
> Review of attachment 8762681 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> * This module implements a simple archive extractor for the PKZIP format.
>  *
>  * The underlying nsZipArchive is NOT thread-safe. Do not pass references
>  * or pointers to it across thread boundaries.
> 
> we could assert is main thread in the ref counting functions to test your
> theory and find the violator. would be good to have in any event
> 
> the other possibility is that ominjar is just releasing it twice somehow..
> have you looked at that? (I haven't).


This is the stack trace for the destructor when running test_system_update.js
The constructor also asserts.

"Assertion failure: NS_IsMainThread() (Not thread safe), at modules/libjar/nsZipArchive.cpp:137"
"#01: ZipArchiveLogger::Release() (modules/libjar/nsZipArchive.cpp:137 (discriminator 2))"
"#02: ~nsZipArchive (modules/libjar/nsZipArchive.cpp:976)"
"#03: nsZipArchive::Release() (modules/libjar/nsZipArchive.cpp:967 (discriminator 24))"
"#04: mozilla::RefPtrTraits<nsZipArchive>::Release(nsZipArchive*) (obj-ff-dbg/dist/include/mozilla/RefPtr.h:40)"
"#05: RefPtr<nsZipArchive>::ConstRemovingRefPtrTraits<nsZipArchive>::Release(nsZipArchive*) (obj-ff-dbg/dist/
"#06: ~RefPtr (obj-ff-dbg/dist/include/mozilla/RefPtr.h:79)"
"#07: ~nsJAR (modules/libjar/nsJAR.cpp:97)"
"#08: ~nsJAR (modules/libjar/nsJAR.cpp:95)"
"#09: nsJAR::Release() (modules/libjar/nsJAR.cpp:114)"
"#10: ~nsCOMPtr (obj-ff-dbg/dist/include/nsCOMPtr.h:405)"
"#11: (anonymous namespace)::OpenSignedAppFile(unsigned int, nsIFile*, nsIZipReader**, nsIX509Cert**) (security/apps/AppSignatureVerification.cpp:870 (discriminator 8))"
"#12: (anonymous namespace)::OpenSignedAppFileTask::CalculateResult() (security/apps/AppSignatureVerification.cpp:963)"
"#13: mozilla::CryptoTask::Run() (security/manager/ssl/CryptoTask.cpp:53)"
Flags: needinfo?(mcmanus)
Component: Networking: JAR → Security: PSM
Flags: needinfo?(mcmanus)
Assignee: valentin.gosu → nobody
Status: ASSIGNED → NEW
Summary: Intermittent browser_updatessl.js,test_system_update.js,browser_username_select_dialog.js | application crashed [@ nsZipArchive::~nsZipArchive()] after Assertion failure: refCnt > 0, at nsZipArchive.cpp:135 → Intermittent browser_updatessl.js,test_system_update.js,browser_username_select_dialog.js,test_MochiKit-Visual.html,test_treeview_date.xul | application crashed [@ nsZipArchive::~nsZipArchive()] after Assertion failure: refCnt > 0, at nsZipArchive.cpp:135
Priority: -- → P3
Whiteboard: [necko-active] → [necko-active][psm-intermittent]
Whiteboard: [necko-active][psm-intermittent] → [psm-intermittent]
See Also: → 1407493
I'm going to take this (but fix later) since it's a dup of bug 1407493, and I'm the assignee of that bug.
Assignee: nobody → xeonchen
Assignee: xeonchen → nobody
Recent failure log: 
https://treeherder.mozilla.org/logviewer.html#?job_id=191333425&repo=mozilla-central&lineNumber=11742

11:11:27     INFO - GECKO(5812) | --DOMWINDOW == 4 (14ADD000) [pid = 5812] [serial = 15] [outer = 00000000] [url = chrome://extensions/content/dummy.xul]
11:11:27     INFO - GECKO(5812) | --DOCSHELL 0DE91800 == 0 [pid = 5812] [id = {494ac4a4-e90f-42b3-9102-44a2488b788c}]
11:11:27     INFO - GECKO(5812) | --DOMWINDOW == 3 (0AF688D0) [pid = 5812] [serial = 3] [outer = 00000000] [url = resource://gre-resources/hiddenWindow.html]
11:11:27     INFO - GECKO(5812) | --DOMWINDOW == 2 (10281400) [pid = 5812] [serial = 157] [outer = 00000000] [url = about:blank]
11:11:27     INFO - GECKO(5812) | --DOMWINDOW == 1 (0AF69380) [pid = 5812] [serial = 8] [outer = 00000000] [url = about:blank]
11:11:27     INFO - GECKO(5812) | --DOMWINDOW == 0 (0D765800) [pid = 5812] [serial = 7] [outer = 00000000] [url = resource://gre-resources/hiddenWindow.html]
11:11:27     INFO - GECKO(5812) | Assertion failure: refCnt > 0, at z:/build/build/src/modules/libjar/nsZipArchive.cpp:133
11:11:27     INFO - GECKO(5812) | #01: nsZipArchive::Release() [modules/libjar/nsZipArchive.cpp:928]
11:11:27     INFO - 
11:11:27     INFO - GECKO(5812) | #02: mozilla::Omnijar::CleanUp() [xpcom/build/Omnijar.cpp:120]
11:11:27     INFO - 
11:11:27     INFO - GECKO(5812) | #03: mozilla::ShutdownXPCOM(nsIServiceManager *) [xpcom/build/XPCOMInit.cpp:1086]
11:11:27     INFO - 
11:11:27     INFO - GECKO(5812) | #04: ScopedXPCOMStartup::~ScopedXPCOMStartup() [toolkit/xre/nsAppRunner.cpp:1406]
11:11:27     INFO - 
11:11:27     INFO - GECKO(5812) | #05: XREMain::XRE_main(int,char * * const,mozilla::BootstrapConfig const &) [toolkit/xre/nsAppRunner.cpp:4937]
11:11:27     INFO - 
11:11:27     INFO - GECKO(5812) | #06: XRE_main(int,char * * const,mozilla::BootstrapConfig const &) [toolkit/xre/nsAppRunner.cpp:5001]
11:11:27     INFO - 
11:11:27     INFO - GECKO(5812) | #07: mozilla::BootstrapImpl::XRE_main(int,char * * const,mozilla::BootstrapConfig const &) [toolkit/xre/Bootstrap.cpp:49]
11:11:27     INFO - 
11:11:27     INFO - GECKO(5812) | #08: NS_internal_main(int,char * *,char * *) [browser/app/nsBrowserApp.cpp:311]
11:11:27     INFO - 
11:11:27     INFO - GECKO(5812) | #09: wmain [toolkit/xre/nsWindowsWMain.cpp:140]
11:11:27     INFO - 
11:11:27     INFO - GECKO(5812) | #10: static int __scrt_common_main_seh() [f:/dd/vctools/crt/vcstartup/src/startup/exe_common.inl:283]
11:11:27     INFO - 
11:11:27     INFO - GECKO(5812) | #11: kernel32.dll + 0x53c45
11:11:27     INFO - 
11:11:27     INFO - GECKO(5812) | #12: ntdll.dll + 0x637f5
11:11:27     INFO - 
11:11:27     INFO - GECKO(5812) | #13: ntdll.dll + 0x637c8
11:11:27     INFO - 
11:11:27     INFO - TEST-INFO | Main app process: exit 1
11:11:27     INFO - Buffered messages finished
11:11:27    ERROR - TEST-UNEXPECTED-FAIL | Last test finished | application terminated with exit code 1
11:11:27     INFO - runtests.py | Application ran for: 0:01:05.737000
11:11:27     INFO - zombiecheck | Reading PID log: c:\users\task_1533120966\appdata\local\temp\tmpv01uqupidlog
11:11:27     INFO - ==> process 5812 launched child process 5440 ("Z:\task_1533120966\build\application\firefox\firefox.exe" -contentproc --channel="5812.0.1399499634\1460591587" -childID 1 -isForBrowser -prefsHandle 2036 -prefMapHandle 2032 -prefsLen 1 -prefMapSize 183162 -schedulerPrefs 0001,2 -parentBuildID 20180801095220 -greomni "Z:\task_1533120966\build\application\firefox\omni.ja" -appomni "Z:\task_1533120966\build\application\firefox\browser\omni.ja" -appdir "Z:\task_1533120966\build\application\firefox\browser" - 5812 "\\.\pipe\gecko-crash-server-pipe.5812" 2112 tab)
11:11:27     INFO - ==> process 5812 launched child process 3400 ("Z:\task_1533120966\build\application\firefox\firefox.exe" -contentproc --channel="5812.6.1183643906\1365667655" -childID 2 -isForBrowser -prefsHandle 1976 -prefMapHandle 2016 -prefsLen 41 -prefMapSize 183162 -schedulerPrefs 0001,2 -parentBuildID 20180801095220 -greomni "Z:\task_1533120966\build\application\firefox\omni.ja" -appomni "Z:\task_1533120966\build\application\firefox\browser\omni.ja" -appdir "Z:\task_1533120966\build\application\firefox\browser" - 5812 "\\.\pipe\gecko-crash-server-pipe.5812" 1996 tab)
11:11:27     INFO - ==> process 5812 launched child process 4920 ("Z:\task_1533120966\build\application\firefox\firefox.exe" -contentproc --channel="5812.12.338378970\389715168" -childID 3 -isForBrowser -prefsHandle 2552 -prefMapHandle 2564 -prefsLen 1380 -prefMapSize 183162 -schedulerPrefs 0001,2 -parentBuildID 20180801095220 -greomni "Z:\task_1533120966\build\application\firefox\omni.ja" -appomni "Z:\task_1533120966\build\application\firefox\browser\omni.ja" -appdir "Z:\task_1533120966\build\application\firefox\browser" - 5812 "\\.\pipe\gecko-crash-server-pipe.5812" 2576 tab)
11:11:27     INFO - ==> process 5812 launched child process 5972 ("Z:\task_1533120966\build\application\firefox\firefox.exe" -contentproc --channel="5812.18.1550180328\1206520725" -childID 4 -isForBrowser -prefsHandle 3404 -prefMapHandle 3380 -prefsLen 6939 -prefMapSize 183162 -schedulerPrefs 0001,2 -parentBuildID 20180801095220 -greomni "Z:\task_1533120966\build\application\firefox\omni.ja" -appomni "Z:\task_1533120966\build\application\firefox\browser\omni.ja" -appdir "Z:\task_1533120966\build\application\firefox\browser" - 5812 "\\.\pipe\gecko-crash-server-pipe.5812" 3400 tab)
11:11:27     INFO - ==> process 5812 launched child process 4076 ("Z:\task_1533120966\build\application\firefox\firefox.exe" -contentproc --channel="5812.24.860685443\1684343874" -childID 5 -isForBrowser -prefsHandle 3616 -prefMapHandle 3604 -prefsLen 7638 -prefMapSize 183162 -schedulerPrefs 0001,2 -parentBuildID 20180801095220 -greomni "Z:\task_1533120966\build\application\firefox\omni.ja" -appomni "Z:\task_1533120966\build\application\firefox\browser\omni.ja" -appdir "Z:\task_1533120966\build\application\firefox\browser" - 5812 "\\.\pipe\gecko-crash-server-pipe.5812" 3472 tab)
11:11:27     INFO - zombiecheck | Checking for orphan process with PID: 5440
11:11:27     INFO - zombiecheck | Checking for orphan process with PID: 3400
11:11:27     INFO - zombiecheck | Checking for orphan process with PID: 5972
11:11:27     INFO - zombiecheck | Checking for orphan process with PID: 4076
11:11:27     INFO - zombiecheck | Checking for orphan process with PID: 4920
11:11:27     INFO - mozcrash Copy/paste: Z:\task_1533120966\build\win32-minidump_stackwalk.exe c:\users\task_1533120966\appdata\local\temp\tmp9nvjwr.mozrunner\minidumps\b4312898-4ed5-48a8-acbd-e241236bfe0b.dmp Z:\task_1533120966\build\symbols
11:11:41     INFO - mozcrash Saved minidump as Z:\task_1533120966\build\blobber_upload_dir\b4312898-4ed5-48a8-acbd-e241236bfe0b.dmp
11:11:41     INFO - mozcrash Saved app info as Z:\task_1533120966\build\blobber_upload_dir\b4312898-4ed5-48a8-acbd-e241236bfe0b.extra
11:11:41     INFO - PROCESS-CRASH | Last test finished | application crashed [@ nsZipArchive::~nsZipArchive()]
11:11:41     INFO - Crash dump filename: c:\users\task_1533120966\appdata\local\temp\tmp9nvjwr.mozrunner\minidumps\b4312898-4ed5-48a8-acbd-e241236bfe0b.dmp
11:11:41     INFO - Operating system: Windows NT
11:11:41     INFO -                   6.1.7601 Service Pack 1
11:11:41     INFO - CPU: x86
11:11:41     INFO -      GenuineIntel family 6 model 63 stepping 2
11:11:41     INFO -      8 CPUs
11:11:41     INFO - 
11:11:41     INFO - GPU: UNKNOWN
11:11:41     INFO - 
11:11:41     INFO - Crash reason:  EXCEPTION_BREAKPOINT
11:11:41     INFO - Crash address: 0x5450d838
11:11:41     INFO - Process uptime: 65 seconds
11:11:41     INFO - 
11:11:41     INFO - Thread 0 (crashed)
11:11:41     INFO -  0  xul.dll!nsZipArchive::~nsZipArchive() [nsZipArchive.cpp:af6a7edf0069549543f2fba6a8ee3ea251b20829 : 935 + 0x1c]
11:11:41     INFO -     eip = 0x5450d838   esp = 0x0018f3a8   ebp = 0x0018f3b4   ebx = 0x0018f3e0
11:11:41     INFO -     esi = 0x00919800   edi = 0x00919800   eax = 0x00000000   ecx = 0x6820c911
11:11:41     INFO -     edx = 0x00000000   efl = 0x00000202
11:11:41     INFO -     Found by: given as instruction pointer in context
11:11:41     INFO -  1  xul.dll!nsZipArchive::Release() [nsZipArchive.cpp:af6a7edf0069549543f2fba6a8ee3ea251b20829 : 928 + 0x5]
11:11:41     INFO -     eip = 0x5450d698   esp = 0x0018f3bc   ebp = 0x0018f3c4
11:11:41     INFO -     Found by: previous frame's frame pointer
11:11:41     INFO -  2  xul.dll!mozilla::Omnijar::CleanUp() [Omnijar.cpp:af6a7edf0069549543f2fba6a8ee3ea251b20829 : 120 + 0x28]
11:11:41     INFO -     eip = 0x53a2cbf4   esp = 0x0018f3cc   ebp = 0x0018f3d0
11:11:41     INFO -     Found by: previous frame's frame pointer
11:11:41     INFO -  3  xul.dll!mozilla::ShutdownXPCOM(nsIServiceManager *) [XPCOMInit.cpp:af6a7edf0069549543f2fba6a8ee3ea251b20829 : 1084 + 0x5]
11:11:41     INFO -     eip = 0x53a2e4ee   esp = 0x0018f3d8   ebp = 0x0018f400
11:11:41     INFO -     Found by: previous frame's frame pointer
11:11:41     INFO -  4  xul.dll!ScopedXPCOMStartup::~ScopedXPCOMStartup() [nsAppRunner.cpp:af6a7edf0069549543f2fba6a8ee3ea251b20829 : 1406 + 0x7]
11:11:41     INFO -     eip = 0x57cc4c14   esp = 0x0018f408   ebp = 0x0018f420
11:11:41     INFO -     Found by: previous frame's frame pointer
11:11:41     INFO -  5  xul.dll!XREMain::XRE_main(int,char * * const,mozilla::BootstrapConfig const &) [nsAppRunner.cpp:af6a7edf0069549543f2fba6a8ee3ea251b20829 : 4937 + 0x17]
11:11:41     INFO -     eip = 0x57cce329   esp = 0x0018f428   ebp = 0x0018f47c
11:11:41     INFO -     Found by: previous frame's frame pointer
11:11:41     INFO -  6  xul.dll!XRE_main(int,char * * const,mozilla::BootstrapConfig const &) [nsAppRunner.cpp:af6a7edf0069549543f2fba6a8ee3ea251b20829 : 5001 + 0xc]
11:11:41     INFO -     eip = 0x57ccedc1   esp = 0x0018f484   ebp = 0x0018f5a8
11:11:41     INFO -     Found by: previous frame's frame pointer
11:11:41     INFO -  7  xul.dll!mozilla::BootstrapImpl::XRE_main(int,char * * const,mozilla::BootstrapConfig const &) [Bootstrap.cpp:af6a7edf0069549543f2fba6a8ee3ea251b20829 : 49 + 0xe]
11:11:41     INFO -     eip = 0x57cde731   esp = 0x0018f5b0   ebp = 0x0018f5bc
11:11:41     INFO -     Found by: previous frame's frame pointer
11:11:41     INFO -  8  firefox.exe!NS_internal_main(int,char * *,char * *) [nsBrowserApp.cpp:af6a7edf0069549543f2fba6a8ee3ea251b20829 : 311 + 0x32]
11:11:41     INFO -     eip = 0x00fe1477   esp = 0x0018f5c4   ebp = 0x0018f720
11:11:41     INFO -     Found by: previous frame's frame pointer
11:11:41     INFO -  9  firefox.exe!wmain [nsWindowsWMain.cpp:af6a7edf0069549543f2fba6a8ee3ea251b20829 : 140 + 0x11]
11:11:41     INFO -     eip = 0x00fe11ca   esp = 0x0018f728   ebp = 0x0018f754
11:11:41     INFO -     Found by: previous frame's frame pointer
Recent failure log:
https://treeherder.mozilla.org/logviewer.html#?job_id=207891199&repo=mozilla-central&lineNumber=84865

INFO - GECKO(5544) | Assertion failure: refCnt > 0, at z:/build/build/src/modules/libjar/nsZipArchive.cpp:133
23:20:09     INFO - GECKO(5544) | #01: nsZipArchive::Release() [modules/libjar/nsZipArchive.cpp:928]
23:20:09     INFO - 
23:20:09     INFO - GECKO(5544) | #02: mozilla::Omnijar::CleanUp() [xpcom/build/Omnijar.cpp:120]
23:20:09     INFO - 
23:20:09     INFO - GECKO(5544) | #03: mozilla::ShutdownXPCOM(nsIServiceManager *) [xpcom/build/XPCOMInit.cpp:1084]
23:20:09     INFO - 
23:20:09     INFO - GECKO(5544) | #04: ScopedXPCOMStartup::~ScopedXPCOMStartup() [toolkit/xre/nsAppRunner.cpp:1429]
23:20:09     INFO - 
23:20:09     INFO - GECKO(5544) | #05: XREMain::XRE_main(int,char * * const,mozilla::BootstrapConfig const &) [toolkit/xre/nsAppRunner.cpp:4950]
23:20:09     INFO - 
23:20:09     INFO - GECKO(5544) | #06: XRE_main(int,char * * const,mozilla::BootstrapConfig const &) [toolkit/xre/nsAppRunner.cpp:5014]
23:20:09     INFO - 
23:20:09     INFO - GECKO(5544) | #07: mozilla::BootstrapImpl::XRE_main(int,char * * const,mozilla::BootstrapConfig const &) [toolkit/xre/Bootstrap.cpp:49]
23:20:09     INFO - 
23:20:09     INFO - GECKO(5544) | #08: NS_internal_main(int,char * *,char * *) [browser/app/nsBrowserApp.cpp:329]
23:20:09     INFO - 
23:20:09     INFO - GECKO(5544) | #09: wmain [toolkit/xre/nsWindowsWMain.cpp:143]
23:20:09     INFO - 
23:20:09     INFO - GECKO(5544) | #10: static int __scrt_common_main_seh() [f:/dd/vctools/crt/vcstartup/src/startup/exe_common.inl:288]
23:20:09     INFO - 
23:20:09     INFO - GECKO(5544) | #11: kernel32.dll + 0x53c45
23:20:09     INFO - 
23:20:09     INFO - GECKO(5544) | #12: ntdll.dll + 0x637f5
23:20:09     INFO - 
23:20:09     INFO - GECKO(5544) | #13: ntdll.dll + 0x637c8
23:20:09     INFO - 
23:20:10     INFO - TEST-INFO | Main app process: exit 1
23:20:10     INFO - Buffered messages finished
23:20:10    ERROR - TEST-UNEXPECTED-FAIL | Last test finished | application terminated with exit code 1
23:20:10     INFO - runtests.py | Application ran for: 0:12:53.006000
23:20:10     INFO - zombiecheck | Reading PID log: c:\users\task_1540507500\appdata\local\temp\tmpszx8trpidlog
23:20:10     INFO - ==> process 4808 launched child process 1312 ("Z:\task_1540507500\build\application\firefox\firefox.exe" -contentproc --channel="4808.0.1081958896\383410715" -childID 1 -isForBrowser -prefsHandle 2076 -prefMapHandle 2072 -prefsLen 1 -prefMapSize 188642 -schedulerPrefs 0001,2 -parentBuildID 20181025215502 -greomni "Z:\task_1540507500\build\application\firefox\omni.ja" -appomni "Z:\task_1540507500\build\application\firefox\browser\omni.ja" -appdir "Z:\task_1540507500\build\application\firefox\browser" - 4808 "\\.\pipe\gecko-crash-server-pipe.4808" 2148 tab)
23:20:10     INFO - ==> process 4808 launched child process 5744 ("Z:\task_1540507500\build\application\firefox\firefox.exe" -contentproc --channel="4808.6.1581833296\1899174950" -childID 2 -isForBrowser -prefsHandle 1960 -prefMapHandle 1796 -prefsLen 151 -prefMapSize 188642 -schedulerPrefs 0001,2 -parentBuildID 20181025215502 -greomni "Z:\task_1540507500\build\application\firefox\omni.ja" -appomni "Z:\task_1540507500\build\application\firefox\browser\omni.ja" -appdir "Z:\task_1540507500\build\application\firefox\browser" - 4808 "\\.\pipe\gecko-crash-server-pipe.4808" 1940 tab)
23:20:10     INFO - ==> process 4808 launched child process 4804 ("Z:\task_1540507500\build\application\firefox\firefox.exe" -contentproc --channel="4808.12.1085368697\1999591781" -childID 3 -isForBrowser -prefsHandle 1936 -prefMapHandle 1476 -prefsLen 191 -prefMapSize 188642 -schedulerPrefs 0001,2 -parentBuildID 20181025215502 -greomni "Z:\task_1540507500\build\application\firefox\omni.ja" -appomni "Z:\task_1540507500\build\application\firefox\browser\omni.ja" -appdir "Z:\task_1540507500\build\application\firefox\browser" - 4808 "\\.\pipe\gecko-crash-server-pipe.4808" 1988 tab)
23:20:10     INFO - ==> process 4808 launched child process 4752 ("Z:\task_1540507500\build\application\firefox\firefox.exe" -contentproc --channel="4808.18.1893933432\1181777938" -childID 4 -isForBrowser -prefsHandle 3212 -prefMapHandle 3220 -prefsLen 8198 -prefMapSize 188642 -schedulerPrefs 0001,2 -parentBuildID 20181025215502 -greomni "Z:\task_1540507500\build\application\firefox\omni.ja" -appomni "Z:\task_1540507500\build\application\firefox\browser\omni.ja" -appdir "Z:\task_1540507500\build\application\firefox\browser" - 4808 "\\.\pipe\gecko-crash-server-pipe.4808" 3236 tab)
23:20:10     INFO - ==> process 4808 launched child process 4656 ("Z:\task_1540507500\build\application\firefox\firefox.exe" -contentproc --channel="4808.24.688938202\1440896364" -childID 5 -isForBrowser -prefsHandle 3432 -prefMapHandle 3100 -prefsLen 8237 -prefMapSize 188642 -schedulerPrefs 0001,2 -parentBuildID 20181025215502 -greomni "Z:\task_1540507500\build\application\firefox\omni.ja" -appomni "Z:\task_1540507500\build\application\firefox\browser\omni.ja" -appdir "Z:\task_1540507500\build\application\firefox\browser" - 4808 "\\.\pipe\gecko-crash-server-pipe.4808" 3472 tab)
23:20:10     INFO - ==> process 1180 launched child process 940 ("Z:\task_1540507500\build\application\firefox\firefox.exe" -contentproc --channel="1180.0.580878187\1617753913" -childID 1 -isForBrowser -prefsHandle 1948 -prefMapHandle 1944 -prefsLen 1 -prefMapSize 190548 -schedulerPrefs 0001,2 -parentBuildID 20181025215502 -greomni "Z:\task_1540507500\build\application\firefox\omni.ja" -appomni "Z:\task_1540507500\build\application\firefox\browser\omni.ja" -appdir "Z:\task_1540507500\build\application\firefox\browser" - 1180 "\\.\pipe\gecko-crash-server-pipe.1180" 2020 tab)
23:20:10     INFO - ==> process 1180 launched child process 4360 ("Z:\task_1540507500\build\application\firefox\firefox.exe" -contentproc --channel="1180.6.1037724763\515251505" -childID 2 -isForBrowser -prefsHandle 2492 -prefMapHandle 2496 -prefsLen 635 -prefMapSize 190548 -schedulerPrefs 0001,2 -parentBuildID 20181025215502 -greomni "Z:\task_1540507500\build\application\firefox\omni.ja" -appomni "Z:\task_1540507500\build\application\firefox\browser\omni.ja" -appdir "Z:\task_1540507500\build\application\firefox\browser" - 1180 "\\.\pipe\gecko-crash-server-pipe.1180" 2508 tab)
23:20:10     INFO - ==> process 4808 launched child process 5060 ("Z:\task_1540507500\build\application\firefox\firefox.exe" -contentproc --channel="4808.30.513033566\190280085" -childID 6 -isForBrowser -prefsHandle 2828 -prefMapHandle 2832 -prefsLen 8444 -prefMapSize 188642 -schedulerPrefs 0001,2 -parentBuildID 20181025215502 -greomni "Z:\task_1540507500\build\application\firefox\omni.ja" -appomni "Z:\task_1540507500\build\application\firefox\browser\omni.ja" -appdir "Z:\task_1540507500\build\application\firefox\browser" - 4808 "\\.\pipe\gecko-crash-server-pipe.4808" 2804 tab)
23:20:10     INFO - ==> process 4808 launched child process 5760 ("Z:\task_1540507500\build\application\firefox\firefox.exe" -contentproc --channel="4808.36.1370876390\303882581" -childID 7 -isForBrowser -prefsHandle 3880 -prefMapHandle 3644 -prefsLen 9571 -prefMapSize 188642 -schedulerPrefs 0001,2 -parentBuildID 20181025215502 -greomni "Z:\task_1540507500\build\application\firefox\omni.ja" -appomni "Z:\task_1540507500\build\application\firefox\browser\omni.ja" -appdir "Z:\task_1540507500\build\application\firefox\browser" - 4808 "\\.\pipe\gecko-crash-server-pipe.4808" 3900 tab)
23:20:10     INFO - ==> process 4808 launched child process 1172 ("Z:\task_1540507500\build\application\firefox\firefox.exe" -contentproc --channel="4808.42.1454757148\667027199" -childID 8 -isForBrowser -prefsHandle 4088 -prefMapHandle 4092 -prefsLen 9764 -prefMapSize 188642 -schedulerPrefs 0001,2 -parentBuildID 20181025215502 -greomni "Z:\task_1540507500\build\application\firefox\omni.ja" -appomni "Z:\task_1540507500\build\application\firefox\browser\omni.ja" -appdir "Z:\task_1540507500\build\application\firefox\browser" - 4808 "\\.\pipe\gecko-crash-server-pipe.4808" 4108 tab)
23:20:10     INFO - ==> process 4808 launched child process 2784 ("Z:\task_1540507500\build\application\firefox\firefox.exe" -contentproc --channel="4808.48.1402378316\907796851" -childID 9 -isForBrowser -prefsHandle 3860 -prefMapHandle 4016 -prefsLen 9764 -prefMapSize 188642 -schedulerPrefs 0001,2 -parentBuildID 20181025215502 -greomni "Z:\task_1540507500\build\application\firefox\omni.ja" -appomni "Z:\task_1540507500\build\application\firefox\browser\omni.ja" -appdir "Z:\task_1540507500\build\application\firefox\browser" - 4808 "\\.\pipe\gecko-crash-server-pipe.4808" 4304 tab)
23:20:10     INFO - ==> process 4808 launched child process 1528 ("Z:\task_1540507500\build\application\firefox\plugin-container.exe" --channel="4808.54.1256370558\1438838474" "C:\Users\task_1540507500\AppData\Local\Temp\tmp7bvpvh.mozrunner\plugins\nptest.dll" "C:\Users\task_1540507500\AppData\LocalLow\Mozilla\Temp-{b5efc573-9453-43b6-bd94-0aba4bd66951}" "Z:\task_1540507500\AppData\Roaming\Adobe\\" -greomni "Z:\task_1540507500\build\application\firefox\omni.ja" -appomni "Z:\task_1540507500\build\application\firefox\browser\omni.ja" -appdir "Z:\task_1540507500\build\application\firefox\browser" - 4808 "\\.\pipe\gecko-crash-server-pipe.4808" 5768 plugin)
23:20:10     INFO - ==> process 4808 launched child process 1236 ("Z:\task_1540507500\build\application\firefox\plugin-container.exe" --channel="4808.58.81738934\1932737702" "C:\Users\task_1540507500\AppData\Local\Temp\tmp7bvpvh.mozrunner\plugins\npswftest.dll" "C:\Users\task_1540507500\AppData\LocalLow\Mozilla\Temp-{b5efc573-9453-43b6-bd94-0aba4bd66951}" "Z:\task_1540507500\AppData\Roaming\Adobe\\" -greomni "Z:\task_1540507500\build\application\firefox\omni.ja" -appomni "Z:\task_1540507500\build\application\firefox\browser\omni.ja" -appdir "Z:\task_1540507500\build\application\firefox\browser" - 4808 "\\.\pipe\gecko-crash-server-pipe.4808" 5848 plugin)
23:20:10     INFO - ==> process 4808 launched child process 5376 ("Z:\task_1540507500\build\application\firefox\firefox.exe" -contentproc --channel="4808.62.596296366\895391119" -childID 10 -isForBrowser -prefsHandle 9076 -prefMapHandle 2252 -prefsLen 10543 -prefMapSize 188642 -schedulerPrefs 0001,2 -parentBuildID 20181025215502 -greomni "Z:\task_1540507500\build\application\firefox\omni.ja" -appomni "Z:\task_1540507500\build\application\firefox\browser\omni.ja" -appdir "Z:\task_1540507500\build\application\firefox\browser" - 4808 "\\.\pipe\gecko-crash-server-pipe.4808" 9052 tab)
23:20:10     INFO - ==> process 4808 launched child process 4452 ("Z:\task_1540507500\build\application\firefox\firefox.exe" -contentproc --channel="4808.68.1964403267\2084177708" -childID 11 -isForBrowser -prefsHandle 9192 -prefMapHandle 9164 -prefsLen 10543 -prefMapSize 188642 -schedulerPrefs 0001,2 -parentBuildID 20181025215502 -greomni "Z:\task_1540507500\build\application\firefox\omni.ja" -appomni "Z:\task_1540507500\build\application\firefox\browser\omni.ja" -appdir "Z:\task_1540507500\build\application\firefox\browser" - 4808 "\\.\pipe\gecko-crash-server-pipe.4808" 9168 tab)
23:20:10     INFO - zombiecheck | Checking for orphan process with PID: 1312
23:20:10     INFO - zombiecheck | Checking for orphan process with PID: 4752
23:20:10     INFO - zombiecheck | Checking for orphan process with PID: 4804
23:20:10     INFO - zombiecheck | Checking for orphan process with PID: 4360
23:20:10     INFO - zombiecheck | Checking for orphan process with PID: 4452
23:20:10     INFO - zombiecheck | Checking for orphan process with PID: 940
23:20:10     INFO - zombiecheck | Checking for orphan process with PID: 5376
23:20:10     INFO - zombiecheck | Checking for orphan process with PID: 5744
23:20:10     INFO - zombiecheck | Checking for orphan process with PID: 1172
23:20:10     INFO - zombiecheck | Checking for orphan process with PID: 1236
23:20:10     INFO - zombiecheck | Checking for orphan process with PID: 4656
23:20:10     INFO - zombiecheck | Checking for orphan process with PID: 1528
23:20:10     INFO - zombiecheck | Checking for orphan process with PID: 5060
23:20:10     INFO - zombiecheck | Checking for orphan process with PID: 5760
23:20:10     INFO - zombiecheck | Checking for orphan process with PID: 2784
23:20:10     INFO - mozcrash Copy/paste: Z:\task_1540507500\build\win32-minidump_stackwalk.exe c:\users\task_1540507500\appdata\local\temp\tmp7bvpvh.mozrunner\minidumps\fcbb2e3a-3b19-4284-b578-589d2d0aebf3.dmp Z:\task_1540507500\build\symbols
23:20:23     INFO - mozcrash Saved minidump as Z:\task_1540507500\build\blobber_upload_dir\fcbb2e3a-3b19-4284-b578-589d2d0aebf3.dmp
23:20:23     INFO - mozcrash Saved app info as Z:\task_1540507500\build\blobber_upload_dir\fcbb2e3a-3b19-4284-b578-589d2d0aebf3.extra
23:20:23     INFO - PROCESS-CRASH | Last test finished | application crashed [@ nsZipArchive::~nsZipArchive()]
23:20:23     INFO - Crash dump filename: c:\users\task_1540507500\appdata\local\temp\tmp7bvpvh.mozrunner\minidumps\fcbb2e3a-3b19-4284-b578-589d2d0aebf3.dmp
23:20:23     INFO - Operating system: Windows NT
23:20:23     INFO -                   6.1.7601 Service Pack 1
23:20:23     INFO - CPU: x86
23:20:23     INFO -      GenuineIntel family 6 model 63 stepping 2
23:20:23     INFO -      8 CPUs
23:20:23     INFO - 
23:20:23     INFO - GPU: UNKNOWN
23:20:23     INFO - 
23:20:23     INFO - Crash reason:  EXCEPTION_BREAKPOINT
23:20:23     INFO - Crash address: 0x5608a388
23:20:23     INFO - Process uptime: 773 seconds
23:20:23     INFO - 
23:20:23     INFO - Thread 0 (crashed)
23:20:23     INFO -  0  xul.dll!nsZipArchive::~nsZipArchive() [nsZipArchive.cpp:4e1ac8b657be50febe961899ddeab9b001906fa0 : 935 + 0x1c]
23:20:23     INFO -     eip = 0x5608a388   esp = 0x0018f434   ebp = 0x0018f440   ebx = 0x0018f470
23:20:23     INFO -     esi = 0x00819800   edi = 0x00819800   eax = 0x00000000   ecx = 0x00000000
23:20:23     INFO -     edx = 0x00000000   efl = 0x00000202
23:20:23     INFO -     Found by: given as instruction pointer in context
23:20:23     INFO -  1  xul.dll!nsZipArchive::Release() [nsZipArchive.cpp:4e1ac8b657be50febe961899ddeab9b001906fa0 : 928 + 0x5]
23:20:23     INFO -     eip = 0x5608a1e8   esp = 0x0018f448   ebp = 0x0018f450
23:20:23     INFO -     Found by: previous frame's frame pointer
23:20:23     INFO -  2  xul.dll!mozilla::Omnijar::CleanUp() [Omnijar.cpp:4e1ac8b657be50febe961899ddeab9b001906fa0 : 120 + 0x28]
23:20:23     INFO -     eip = 0x55558834   esp = 0x0018f458   ebp = 0x0018f45c
23:20:23     INFO -     Found by: previous frame's frame pointer
23:20:23     INFO -  3  xul.dll!mozilla::ShutdownXPCOM(nsIServiceManager *) [XPCOMInit.cpp:4e1ac8b657be50febe961899ddeab9b001906fa0 : 1082 + 0x5]
23:20:23     INFO -     eip = 0x5555a27d   esp = 0x0018f464   ebp = 0x0018f490
23:20:23     INFO -     Found by: previous frame's frame pointer
23:20:23     INFO -  4  xul.dll!ScopedXPCOMStartup::~ScopedXPCOMStartup() [nsAppRunner.cpp:4e1ac8b657be50febe961899ddeab9b001906fa0 : 1429 + 0x7]
23:20:23     INFO -     eip = 0x59936be4   esp = 0x0018f498   ebp = 0x0018f4b0
23:20:23     INFO -     Found by: previous frame's frame pointer
23:20:23     INFO -  5  xul.dll!XREMain::XRE_main(int,char * * const,mozilla::BootstrapConfig const &) [nsAppRunner.cpp:4e1ac8b657be50febe961899ddeab9b001906fa0 : 4950 + 0x18]
23:20:23     INFO -     eip = 0x59940a3d   esp = 0x0018f4b8   ebp = 0x0018f50c
23:20:23     INFO -     Found by: previous frame's frame pointer
23:20:23     INFO -  6  xul.dll!XRE_main(int,char * * const,mozilla::BootstrapConfig const &) [nsAppRunner.cpp:4e1ac8b657be50febe961899ddeab9b001906fa0 : 5014 + 0xc]
23:20:23     INFO -     eip = 0x59941391   esp = 0x0018f514   ebp = 0x0018f640
23:20:23     INFO -     Found by: previous frame's frame pointer
23:20:23     INFO -  7  xul.dll!mozilla::BootstrapImpl::XRE_main(int,char * * const,mozilla::BootstrapConfig const &) [Bootstrap.cpp:4e1ac8b657be50febe961899ddeab9b001906fa0 : 49 + 0xe]
23:20:23     INFO -     eip = 0x599540b1   esp = 0x0018f648   ebp = 0x0018f654
23:20:23     INFO -     Found by: previous frame's frame pointer
23:20:23     INFO -  8  firefox.exe!NS_internal_main(int,char * *,char * *) [nsBrowserApp.cpp:4e1ac8b657be50febe961899ddeab9b001906fa0 : 329 + 0x32]
23:20:23     INFO -     eip = 0x00331477   esp = 0x0018f65c   ebp = 0x0018f7b8
23:20:23     INFO -     Found by: previous frame's frame pointer
23:20:23     INFO -  9  firefox.exe!wmain [nsWindowsWMain.cpp:4e1ac8b657be50febe961899ddeab9b001906fa0 : 143 + 0x11]
23:20:23     INFO -     eip = 0x003311cd   esp = 0x0018f7c0   ebp = 0x0018f7e4
23:20:23     INFO -     Found by: previous frame's frame pointer
23:20:23     INFO - 10  firefox.exe!static int __scrt_common_main_seh() [exe_common.inl : 288 + 0x1c]
23:20:23     INFO -     eip = 0x0038e2f8   esp = 0x0018f7ec   ebp = 0x0018f82c
23:20:23     INFO -     Found by: previous frame's frame pointer
23:20:23     INFO - 11  kernel32.dll!BaseThreadInitThunk + 0x12
23:20:23     INFO -     eip = 0x77de3c45   esp = 0x0018f834   ebp = 0x0018f838
23:20:23     INFO -     Found by: previous frame's frame pointer
23:20:23     INFO - 12  ntdll.dll!CreatePipe + 0x231
23:20:23     INFO -     eip = 0x77ca37f5   esp = 0x0018f840   ebp = 0x0018f878
23:20:23     INFO -     Found by: call frame info
23:20:23     INFO - 13  ntdll.dll!CreatePipe + 0x204
23:20:23     INFO -     eip = 0x77ca37c8   esp = 0x0018f880   ebp = 0x0018f890
23:20:23     INFO -     Found by: call frame info
Keywords: assertion
Summary: Intermittent browser_updatessl.js,test_system_update.js,browser_username_select_dialog.js,test_MochiKit-Visual.html,test_treeview_date.xul | application crashed [@ nsZipArchive::~nsZipArchive()] after Assertion failure: refCnt > 0, at nsZipArchive.cpp:135 → Intermittent Assertion failure: refCnt > 0, at /builds/worker/workspace/build/src/modules/libjar/nsZipArchive.cpp:133
Severity: normal → S3
Status: NEW → RESOLVED
Closed: 9 years ago1 year ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: