1185568 - Disabling health reporter and metrics breaks the Back button

Status: RESOLVED FIXED

(Firefox :: Tours, defect)

Description

[[e-mail]]

If you customise your local build to disable health reporter and metrics then the Back button no longer works.

This appears to be because UITour.jsm unconditionally tries to load Metrics.jsm in order to define the DAILY_DISCRETE_TEXT_FIELD constant which never gets used (because the health reporter is disabled). (The fact that UITour.jsm uses a lazy getter is not much use when the module is needed for a top-level constant.)

However other parts of the browser try to load UITour.jsm and therefore fail.

Comment 1

[Matthew N. [:MattN]]

(In reply to [e-mail] from comment #0)
> If you customise your local build to disable health reporter and metrics
> then the Back button no longer works.

Is this is a supported configuration?

If not, I would take a straightforward patch otherwise this is WONTFIX until a patch appears.

Comment 2

[[e-mail]]

Well, I can work around the problem by #ifdefing the definition of UITourMetricsProvider but I'm not sure whether to use MOZ_SERVICES_HEALTHREPORT or MOZ_SERVICES_METRICS.

Comment 3

[Georg Fritzsche [:gfritzsche]]

(In reply to Matthew N. [:MattN] from comment #1)
> (In reply to [e-mail] from comment #0)
> > If you customise your local build to disable health reporter and metrics
> > then the Back button no longer works.
> 
> Is this is a supported configuration?

Hm, i'm not sure if we have to support this for any distributions.
In general we are working with the assumption that data recording is always available on desktop (to power selfsupport and potentially other features).
I thought we have the flags for other products etc., but i'd have to investigate that.

(In reply to [e-mail] from comment #2)
> Well, I can work around the problem by #ifdefing the definition of
> UITourMetricsProvider but I'm not sure whether to use
> MOZ_SERVICES_HEALTHREPORT or MOZ_SERVICES_METRICS.

FWIW, MOZ_SERVICES_HEALTHREPORT is fine here.

Comment 4

[[e-mail]]

Attachment: Possible patch

I moved the definition of DAILY_DISCRETE_TEXT_FIELD so it would all fall under the same #ifdef.

Comment 5

[Georg Fritzsche [:gfritzsche]]

Thanks Neil.

Comment 6

[[e-mail]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b02f91b29878

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b02f91b29878