1185599 - Version control abstraction module

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Andrew Halberstadt [:ahal]]

Git is becoming more and more popular among developers, and we are starting to support it more and more in our tooling. We have several places in the tree that attempt to provide an abstraction layer over git vs hg:

* https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/mozharness/base/vcs
* https://dxr.mozilla.org/mozilla-central/source/python/mozversioncontrol
* https://dxr.mozilla.org/mozilla-central/source/testing/tools/autotry/autotry.py#35

Would be nice to have a standard module to implement this abstraction. The mozharness implementation is by far the most complete, but it is tightly coupled to the rest of mozharness.

Comment 1

[Andrew Halberstadt [:ahal]]

https://dxr.mozilla.org/mozilla-central/source/python/mozlint/mozlint/vcs.py
https://dxr.mozilla.org/mozilla-central/source/tools/tryselect/vcs.py

Comment 2

[(not currently active) Ted Mielczarek]

I believe I expanded mozversioncontrol (which wasn't actually in use at the time) because I wanted something to use in `mach vendor rust`. Consolidating these various implementations would be nice, I'm not fussed where it winds up.

Comment 3

[Gregory Szorc [:gps]]

mozversioncontrol is the answer here. That package exists. What we haven't done is consolidate all VCS code to use it.

I do have a bit of code in bug 1393242 to refactor the API a bit. It is probably best holding off any major refactoring until that series lands because I switch the Repository class to use context managers to facilitate faster operations.

Comment 4

[Andrew Halberstadt [:ahal]]

Agree mozversioncontrol is the right place for this, but I was planning to use this bug to do the actual consolidation. I guess I can file new bugs per module instead.