Closed Bug 1185614 Opened 9 years ago Closed 9 years ago

Allow accessing reviews for apps that aren't available in your region

Categories

(Marketplace Graveyard :: API, defect, P3)

Avenir

Tracking

(Not tracked)

VERIFIED FIXED
2015-09-01

People

(Reporter: mstriemer, Assigned: lucky.lavish, Mentored)

References

Details

(Whiteboard: [good first bug][lang=py])

Attachments

(1 file)

If you visit the detail page for an app that isn't available in your region you don't see anything in the reviews section, even if the app has reviews. This is because the reviews API is returning a 403. We shouldn't restrict this data based on the user's region.

Example app: https://marketplace-dev.allizom.org/app/exquisite-sandwich-12/?region=ca

API request: https://marketplace-dev.allizom.org/api/v2/apps/rating/?app=exquisite-sandwich-12&dev=desktop&doc_type=webapp&lang=en-US&limit=24&region=ca
API response: 403 FORBIDDEN - {"detail":"The app requested is not public or not available in region \"ca\"."}
Severity: normal → major
Priority: -- → P3
See Also: → 989181
This should be accessible to people familiar with Python and Django, marking as good first bug and setting me as mentor.
Whiteboard: [good first bug][lang=py][mentor=mat]
PR :https://github.com/mozilla/zamboni/pull/3277

Please verify.
Flags: needinfo?(mpillard)
Assignee: nobody → lucky.lavish
Flags: needinfo?(mpillard)
Fixed in https://github.com/mozilla/zamboni/commit/961603e55babd28b4625be6c39a63c6265ebbeca

Thanks, Lavish!

Note to QA: *posting* a review for an app not available in your region is still impossible - it's accessing the reviews *via the API* that is now possible.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2015-09-01
Mentor: mpillard
Whiteboard: [good first bug][lang=py][mentor=mat] → [good first bug][lang=py]
Verified as fixed : http://screencast.com/t/dQV0OjNP
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: