Closed
Bug 1185616
Opened 10 years ago
Closed 10 years ago
remove optimization-related hacks in sqlite's Makefile.in
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox42 fixed)
RESOLVED
FIXED
mozilla42
| Tracking | Status | |
|---|---|---|
| firefox42 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(1 file)
|
1.27 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
The Mac-specific MODULE_OPTIMIZE_FLAGS was presumably related to the
ancient version of gcc we used to use on the Mac. Ideally, clang will
not have the same issues.
By the same token, the Windows-specific MODULE_OPTIMIZE_FLAGS was due to
MSVC 2005. Ideally, the pertinent crashes have been fixed in MSVC 2013
and above.
|
Assignee | |
Comment 1•10 years ago
|
||
Currently running this through try on Mac and Win32 PGO. I don't know if those
will actually show up any problems, so this patch is mostly a "hey, we've
upgraded to better compilers, I bet the problems went away" sort of patch.
Attachment #8636127 -
Flags: review?(mh+mozilla)
|
||
Updated•10 years ago
|
Attachment #8636127 -
Flags: review?(mh+mozilla) → review+
|
||
Comment 3•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•