remove optimization-related hacks in sqlite's Makefile.in

RESOLVED FIXED in Firefox 42

Status

RESOLVED FIXED
3 years ago
6 months ago

People

(Reporter: froydnj, Assigned: froydnj)

Tracking

unspecified
mozilla42

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
The Mac-specific MODULE_OPTIMIZE_FLAGS was presumably related to the
ancient version of gcc we used to use on the Mac.  Ideally, clang will
not have the same issues.

By the same token, the Windows-specific MODULE_OPTIMIZE_FLAGS was due to
MSVC 2005.  Ideally, the pertinent crashes have been fixed in MSVC 2013
and above.
(Assignee)

Comment 1

3 years ago
Created attachment 8636127 [details] [diff] [review]
remove optimization-related hacks in sqlite's Makefile.in

Currently running this through try on Mac and Win32 PGO.  I don't know if those
will actually show up any problems, so this patch is mostly a "hey, we've
upgraded to better compilers, I bet the problems went away" sort of patch.
Attachment #8636127 - Flags: review?(mh+mozilla)
Attachment #8636127 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/782e9a74bd4a
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42

Updated

6 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.