1185688 - [Bluetooth] If user accepts pair request through notification, they receive a pop up saying the request is expired.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Nicholas Nelson [:NicholasN]]

Attachment: logcat_bluetooth.txt

Description:
The user has two devices with bluetooth enabled and set visible to all. A pair request is sent from one device, and the other device is locked. If the user of the locked device swipes right to unlock they will receive the pairing pop up and can pair successfully. However, if they tap the notification and accept the pair request from there, they will receive an error that the request expired. This appears to happen regardless of how fast the user accepts the request. It seems that the pairing does not actually fail, and it's just triggering the pop up. When the user who received the pop up goes into settings afterward, the other device is in the paired devices slot and files can be transferred between them.


Repro Steps:
1) Update two Aries devices to 20150720101908
2) On both devices, go to Settings > Bluetooth.
3) Turn on bluetooth and enable Visible to All.
4) Lock one device, and select that device's name from the second device.
5) Tap accept on the device that sent the request.
6) On the locked device, tap the notification and then accept request.


Actual:
A pop up appears saying the request cannot be completed because it expired.


Expected:
The two devices are paired successfully.


Notes:

Environmental Variables:
Device: Aries 2.5
Build ID: 20150720101908
Gaia: a47e0c58dd1340a17be7cc96ccd90fcad15a922b
Gecko: 5df788c56ae7
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 42.0a1 (2.5)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0


Repro frequency: 4/4
See attached: video clip, logcat

Comment 1

[Nicholas Nelson [:NicholasN]]

Issue also occurs on flame 2.5 and Flame 2.2, but not Flame 2.1.

Actual Result:

A pop up appears saying the request cannot be completed because it expired.

Environmental Variables:
Device: Flame 2.5
BuildID: 20150720010206
Gaia: 3fac3ed7b8c887351098ffc677769ddc36abb3d0
Gecko: 202e9233d130
Gonk: a4f6f31d1fe213ac935ca8ede7d05e47324101a4
Version: 42.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

Flame 2.2

Actual Result:

The request expired pop up flashes on screen briefly before the homescreen appears.

Environmental Variables:
Device: Flame 2.2
BuildID: 20150720002503
Gaia: e1e6317f17a840b19af9dbb25f5a771d8d9fa161
Gecko: e2d1f1f55803
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Flame 2.1

Actual Result:

The devices pair correctly, with no error pop ups.

Environmental Variables:
Device: Flame 2.1
BuildID: 20150720001205
Gaia: cc24cce17ab2ebf79f6505103da714fc65bc5ec1
Gecko: 29d54b125d3a
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 34.0 (2.1) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 2

[Peter Bylenga [:PBylenga]]

NI on component owner for nomination decision, device still pairs but gives error message that it expired.

Comment 3

[Ben Tian (inactive)]

ni? gaia dev Fred.

Fred, please hlep check this gaia pairing request bug.

Comment 4

[Teri Wen [:twen]]

Didn't get recreate the first time, but after unpair and the second time pairing was the error. Device seems to stuck on pairing with device. Maybe a syncing issue. 

Flame 2.5

Gaia-Rev        3fac3ed7b8c887351098ffc677769ddc36abb3d0
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/202e9233d130
Build-ID        20150720010206
Version         42.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150720.044158
FW-Date         Mon Jul 20 04:42:10 EDT 2015
Bootloader      L1TC000118D0

Comment 5

[[e-mail]]

The original steps is not reproducible. 
Removed step 5 then can always see `Bluetooth pairing request expired. Try to pair again.` message dialog.


Steps:
1) Update two flame devices (A, B) to 20150720101908
2) On both devices, go to Settings > Bluetooth.
3) Turn on bluetooth and enable Visible to All in device A.
4) Lock device A, and select that device's name from the device B.
6) On the locked device A, tap & open the notification and then accept request.

See the  `Bluetooth pairing request expired. Try to pair again.` dialog.

5) Tap accept on the device B that sent the request.

Then the devices are actually paired.


It means BT can be paired successfully but there's something wrong in gaia paired procedure.

Comment 6

[[e-mail]]

In pair manager, when notification is clicked, it always show the `Bluetooth pairing request expired. ` message no mater you accept pairing or not.

https://github.com/mozilla-b2g/gaia/blob/master/apps/bluetooth/js/modules/pair_manager.js#L298

We need check if the pendingPairing object is still exist (not received the 'bluetooth-cancel' event yet) before showing the expired dialog.

Comment 7

[GitHub Autolander Bot]

Attachment: [gaia] gasolin:issue-1185688 > mozilla-b2g:master

Comment 8

[[e-mail]]

WIP: fixed pair manager part, test with unexpired/expired cases ok. But the new issue is appeared when tapping notification and cancel the pair manager request, the window shows blank and wont be closed.

Comment 9

[[e-mail]]

Comment on attachment 8638446 [details] [review]
[gaia] gasolin:issue-1185688 > mozilla-b2g:master

As above comment the PR fixed the pair manager and shows the expire dialog in correct manner.

The cancel/close button works well in normal BT pairing request and the flow to PairView is identical after tap the notification on lockscreen, so the new issue is more likely related to window management with attention window. I'd like to fire a followup bug to handle with that specific issue.

Comment 10

[[e-mail]]

Test between device and desktop, it works fine without issue. Will check with shawn if above comment is a known issue.

merged https://github.com/mozilla-b2g/gaia/commit/aeaa33cfc1a4850aeba246377dcc443722bf24d6

thanks!

Comment 12

[Shally Li（leave from Mozilla）]

This bug has been verified as "fail" on latest build of Flame KK 2.5 and Aires KK 2.5 by the STR in comment 0 & comment 5.

Actual results: after accepting the request, it has no pop-up prompt message saying that the request is expired, but it shows black empty screen and can't return to bluetooth settings view. After accepting the request on the device B that sent the request, they are paired successfully.

See attachments: verify_fail_Aries_v2.5.3gp
Reproduce rate: 7/10


Device: Flame KK 2.5 (Fail)
Build ID               20150810150206
Gaia Revision          9a8880a95ee4a4aea7895d4e2bcab31bc49ea281
Gaia Date              2015-08-10 16:01:11
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/8cba870a352c
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150810.183734
Firmware Date          Mon Aug 10 18:37:46 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5(Fail)
Build ID               20150810201912
Gaia Revision          fa89e03dc489e79baa0e74cb1d205260c7924caa
Gaia Date              2015-08-10 10:07:57
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/3f135a8ead22
Gecko Version          43.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150810.194258
Firmware Date          Mon Aug 10 19:43:05 UTC 2015
Bootloader             s1


Note:
I will submit a new bug for tracking this bug.

Comment 13

[Shally Li（leave from Mozilla）]

Attachment: verify_fail_Aries_v2.5.3gp

Comment 14

[Shally Li（leave from Mozilla）]

The following up bug is Bug 1193210.