1185712 - Gecko Profiler fails with cryptic errors when a Private Browsing window is open

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[Daniel Holbert [:dholbert]]

STR:
 1. Install Gecko Profiler Add-on
 2. Open a Private Browsing window.
 3. Try to start Gecko Profiler (with Ctrl-Shift-1 or with "Start" button in profiler button-menu on browser toolbar)

ACTUAL RESULTS:
* Ctrl-Shift-1 has no effect, and produces this error message in error console:
{
NS_ERROR_NOT_AVAILABLE: Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsIProfiler.StartProfiler]
main.js:417:0
}

* "Start" button in button-menu has no effect, and produces this error message in error console:
{
geckoprofiler:Exception { message: "Component returned failure code: 0x…", result: 2147746065, name: "NS_ERROR_NOT_AVAILABLE", filename: "resource://gre/modules/commonjs/too…", lineNumber: 417, columnNumber: 0, inner: null, data: null, stack: "Profiler.prototype._profiler_start@…", location: XPCWrappedNative_NoHelper }
core.js:106
}

EXPECTED RESULTS: A clearer failure message. (BenWa tells me the profiler's intentionally disabled when a PB window is open, so failure is expected; but we should be clearer that it's intentionally disabled & why, instead of just looking like we're tripping over something that's busted.)

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

This was effectively fixed a while ago, at the latest when moving away from the add-on.

Comment 2

[Julien Wajsberg [:julienw]]

And also we now support private browsing profiling too.