1185733 - [Dialer] Phone will vibrate 3 times when dialing numbers from dialer app while in a call

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Adam Alldredge [:AdamA][Inactive]]

Attachment: logcat

Description:
If the user is in a phone call then returns to the homescreen and opens the phone app the phone will vibrate 3 times after the user dials any number.

Repro Steps:
1) Update a Aries to 20150720101908
2) Make or receive a call from another device
3) Press the home button
4) Open the dialer app
5) Press a number
6) Observe phone vobration

Actual:
The phone will vibrate 3 times after a number is pressed

Expected:
It is expected that the phone does not vibrate excessivelu after dialing numbers

Environmental Variables:
Device: Aries 2.5 [Full Flash]
Build ID: 20150720101908
Gaia: a47e0c58dd1340a17be7cc96ccd90fcad15a922b
Gecko: 5df788c56ae7
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 42.0a1 (2.5)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

Repro frequency: (2/3, 100%, etc.)/
See attached: video clip(https://youtu.be/TL3MXUVohsg), logcat

Comment 1

[Adam Alldredge [:AdamA][Inactive]]

This issue DOES occur on Flame 2.5.

Environmental Variables:
Device: Flame 2.5 [Full Flash]
BuildID: 20150720010206
Gaia: 3fac3ed7b8c887351098ffc677769ddc36abb3d0
Gecko: 202e9233d130
Gonk: a4f6f31d1fe213ac935ca8ede7d05e47324101a4
Version: 42.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

Result:
The phone will vibrate 3 times after a number is pressed
-------------------------------------------
This issue DOES NOT occur on Flame 2.2.

Environmental Variables:
Device: Flame 2.2 [Full Flash]
BuildID: 20150720002503
Gaia: e1e6317f17a840b19af9dbb25f5a771d8d9fa161
Gecko: e2d1f1f55803
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Result:
the phone vibrates once as the button is pressed

Comment 2

[Peter Bylenga [:PBylenga]]

[Blocking Requested - why for this release]:
Very noticeable UX regression.

Requesting a window.

Comment 3

[Johan Lorenzo [:jlorenzo]]

Comms triage: Regression on a standard dialer use case.

Comment 4

[Duane Dixon [:ddixon]]

Mozilla Inbound Regression Window:

Last Working

Device: Flame 2.5
BuildID: 20150710180250
Gaia: e4b63559eba364892867eb381c3002d6518e5d6a
Gecko: ee99ebac7761
Version: 42.0a1 (2.5) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

First Broken

Device: Flame 2.5
BuildID: 20150710180953
Gaia: e4b63559eba364892867eb381c3002d6518e5d6a
Gecko: 91846db1056c
Version: 42.0a1 (2.5) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

Last Working Gecko and First Broken Gaia
Issue DOES NOT occur here. 
Gaia: e4b63559eba364892867eb381c3002d6518e5d6a
Gecko: ee99ebac7761

Last Working Gaia and First Broken Gecko
Issue DOES occur here. 
Gaia: e4b63559eba364892867eb381c3002d6518e5d6a
Gecko: 91846db1056c

Mozilla Inbound Gecko Pushlog: 
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=ee99ebac7761&tochange=91846db1056c


Possible Cause:
https://bugzilla.mozilla.org/show_bug.cgi?id=1113086

Comment 5

[KTucker [:KTucker][Inactive 3/4/2016]]

Andrea, can you take a look at this please? This looks to be another fallout from the landing for bug 1113086.

Comment 6

[Andrea Marchesini [:baku]]

I move the NI to Alastor, hoping it's a gaia bug.

Comment 7

[Alastor Wu [:alwu]]

Hi, Adam,
What is the normal situation? just vibrates one time or not vibrates at all?
Thanks!

Comment 8

[Alastor Wu [:alwu]]

I probably find the root cause, it seems that the gaia calls extra vibrate().
I would discuss this issue with Evan later.

Comment 9

[Evan Tseng [:evanxd]]

Looks like this is not a bug for Audio Channel Service in gaia. In the spec[1] of audio channel management, a "notification" sound will be muted but system will vibrate when user is on a phone. And that's why have have 3 times vibration in the situation.

For following the spec, we should use "system" type to instead of "notification" type for the click sounds played in dialer pad. Then the click sounds(system type) will be played without any vibration from the Audio Channel Service when user is on a phone.

[1]: https://bug1068219.bmoattachments.org/attachment.cgi?id=8579177

Comment 10

[Alastor Wu [:alwu]]

As comment9 said, we need to use the "system" type to replace the "notification" type. 
The system type would be implemented in bug1142933.

Comment 11

[GitHub Autolander Bot]

Attachment: [gaia] alastor0325:bug-1185733 > mozilla-b2g:master

Comment 12

[Alastor Wu [:alwu]]

Comment on attachment 8637728 [details] [review]
[gaia] alastor0325:bug-1185733 > mozilla-b2g:master

Hi, Gabriele,
Could you help me review this patch?
According the UX sound spec [1], we should use the "system" type for the dialer pad. 

This bug is because we use the "notification" type. When the dialer pad want to playback sound during the telephony, the competing result from the audio channel controller is to vibrate. Therefore, both dialer pad and audio channel controller called the vibrate(), that is why we got lots of vibrations.

Another thing is that we shouldn't use the telephony type for any non-telephony usage. When the call state is INCALL, all the sound would be came out from the speaker, you don't need extra setting for the sound.

Very appreciate :)

[1] https://bug1068219.bmoattachments.org/attachment.cgi?id=8579177#12

Comment 13

[Gabriele Svelto [:gsvelto]]

Comment on attachment 8637728 [details] [review]
[gaia] alastor0325:bug-1185733 > mozilla-b2g:master

Thanks Alastor, that's a bit of the spec I had overlooked, this is most likely going to fix other similar bugs that were reported in the past. This is an r- because of a few related issues:

- You have to fix the unit-tests under apps/communications/dialer/test/unit/keypad_test.js, once that's done feel free to land.

- The callscreen app manifest has to be updated so that it has the right permission

- The emergency-call app also uses the 'notification' channel for the audible touch tones, you'll have to fix that too (plus the manifest and unit-tests)

Comment 14

[Alastor Wu [:alwu]]

Attachment: Patch : change audio channel type to system

Hi, Gabriele,
Could you help me review this patch?
Add the system type to other files.
Very appreciate :)

Comment 15

[Gabriele Svelto [:gsvelto]]

Comment on attachment 8639240 [details] [review]
Patch : change audio channel type to system

Excellent, thanks for fixing this.

Comment 16

[Evan Tseng [:evanxd]]

master: https://github.com/mozilla-b2g/gaia/commit/a8319543833b08e986fa3ed590faeb2624bf1683

Comment 19

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest nightly build of Flame KK 2.5 and Aires KK 2.5 by the STR in comment 0.

Actual results: While in a call, phone will vibrate 1 time after a number is pressed in dialer app.
See attachment: verified_Flame_v2.5.3gp
Reproduce rate: 0/10


Device: Flame KK 2.5 (Pass)
Build ID               20150802150204
Gaia Revision          2ca27bbdd84526c6a3b198d9cf10f2caff1dadde
Gaia Date              2015-07-31 08:23:31
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/32712cd01159
Gecko Version          42.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150802.183402
Firmware Date          Sun Aug  2 18:34:15 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5(Pass)
Build ID               20150801110932
Gaia Revision          2ca27bbdd84526c6a3b198d9cf10f2caff1dadde
Gaia Date              2015-07-31 08:23:31
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/32712cd01159
Gecko Version          42.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150801.105449
Firmware Date          Sat Aug  1 10:54:56 UTC 2015
Bootloader             s1

Comment 20

[Shally Li（leave from Mozilla）]

Attachment: verified_Flame_v2.5.3gp