JavaScript strict warnings in showbuilds.cgi

VERIFIED FIXED

Status

Webtools Graveyard
Tinderbox
VERIFIED FIXED
16 years ago
4 years ago

People

(Reporter: WeirdAl, Assigned: Chris McAfee)

Tracking

Details

Attachments

(1 attachment)

1.68 KB, patch
Christopher Aillon (sabbatical, not receiving bugmail)
: review+
Details | Diff | Splinter Review
(Reporter)

Description

16 years ago
Warning: reference to undefined property document.layers
Source File: http://tinderbox.mozilla.org/showbuilds.cgi?tree=SeaMonkey
Line: 73

(clicking one link in guilty column, above strict warning repeated 13 times!)

Warning: reference to undefined property document.layers
Source File: http://tinderbox.mozilla.org/showbuilds.cgi?tree=SeaMonkey
Line: 104

(clicking one star link, above strict warning repeated 13 times)

Why are we using document.layers to detect for a Netscape 4 browser?
http://developer.netscape.com/evangelism/tools/practical-browser-sniffing/

See bug 81279 for indications why throwing strict warnings en masse is a Bad Thing.

Mozilla/5.0 (Windows; U; Win98; en-US; rv:0.9.7+) Gecko/20020106
The fact that it's repeated 13 times is bug 104549

Comment 2

16 years ago
Created attachment 63925 [details] [diff] [review]
test for undefined

in isn't available in nc4 which makes detection so much fun.
Attachment #63925 - Flags: review+
Comment on attachment 63925 [details] [diff] [review]
test for undefined

this'll do it.	r=caillon
Comment on attachment 63925 [details] [diff] [review]
test for undefined

Um, would you fix your quotes first actually?  :)  Then r=me

Comment 5

16 years ago
done :)
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
(Reporter)

Comment 6

16 years ago
Cool beans.  Thanks, guys.  Took me a moment in #mozillazine to see why you
didn't use the sniffer.
Status: RESOLVED → VERIFIED
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.