118576 - JavaScript strict warnings in enter_bug.cgi

Status: VERIFIED DUPLICATE of bug 95567

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Alex Vincent [:WeirdAl]]

Warning: function onclick does not always return a value
Source Code:
if (this.form.short_desc.value =='') { alert('Please enter a summary sentence
for this bug.'); return false; }

Line 513 of http://lxr.mozilla.org/mozilla/source/webtools/bugzilla/enter_bug.cgi

Suggest editing the line to say:

 <INPUT TYPE=\"submit\" VALUE=\"    Commit    \" ONCLICK=\"if
(this.form.short_desc.value =='') { alert('Please enter a summary sentence for
this bug.'); return false; }; return true;\">

Comment 1

[David D. Kilzer (ddk)]

Attachment: Patch v.1

Patch described in poster's comments.

Comment 2

[David D. Kilzer (ddk)]

Taking bug since I posted a patch.  This is a pretty trivial fix.

Setting milestone to 2.18 (though fix is trivial enough for 2.16).

Comment 3

[David D. Kilzer (ddk)]

BTW, Alex, which browser reported this warning?  A cut-n-paste of the
USER_AGENT string from near the bottom ofthis web page will do:

  http://bugzilla.mozilla.org/enter_bug.cgi?product=Bugzilla

Mozilla-0.9.6 for Linux doesn't complain about the JavaScript in
question.  Neither does Netsacpe Communicator 4.77 for Linux.

Comment 4

[David D. Kilzer (ddk)]

*** This bug has been marked as a duplicate of 95567 ***

Comment 5

[Henrik Gemal]

Verified dupe

Comment 6

[Dave Miller [:justdave]]

clearing target milestone on resolved non-FIXED bugs so they'll get re-triaged
if they get reopened.