1185765 - [Browser][Aries] the Address/search bar doesn’t cover the whole screen when it is in landscape mode

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[Adam Alldredge [:AdamA][Inactive]]

Attachment: logcat

Description:
If the user is in landscape mode in the browser and clicks on the URL/Search bar it will not cover the whole screen. you will be able to see some elements of the search bar below it.

Repro Steps:
1) Update a Aries to 20150720101908
2) Open browser
3) Turn phone to landscape mode
4) Click on the address bar
5) Observe address bar

Actual:
The address bar does not cover the whole screen

Expected:
It is expected the address bar covers the width of the screen

Environmental Variables:
Device: Aries 2.5 [Full Flash]
Build ID: 20150720101908
Gaia: a47e0c58dd1340a17be7cc96ccd90fcad15a922b
Gecko: 5df788c56ae7
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 42.0a1 (2.5)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

Repro frequency: 10/10
See attached: screenshot, logcat

Comment 1

[Adam Alldredge [:AdamA][Inactive]]

This issue DOES NOT occur on Flame 2.5.

Environmental Variables:
Device: Flame 2.5 [Full Flash]
BuildID: 20150720010206
Gaia: 3fac3ed7b8c887351098ffc677769ddc36abb3d0
Gecko: 202e9233d130
Gonk: a4f6f31d1fe213ac935ca8ede7d05e47324101a4
Version: 42.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

Result:
The address bar covers the width of the screen

Comment 2

[Adam Alldredge [:AdamA][Inactive]]

Attachment: Address bar not cover

Comment 3

[Gregor Wagner [:gwagner]]

Dale, can you take a look?

Comment 4

[Dale Harvey (:daleharvey)]

Will do

Comment 5

[Dale Harvey (:daleharvey)]

This got regressed by https://bugzilla.mozilla.org/show_bug.cgi?id=1177477 and since you are in the middle of a bunch of rocketbar work (https://github.com/mozilla-b2g/gaia/commit/e3e4cba7d400a0913bc247b0fd51a47dc9e4c5f3) is it ok for you to take this Alberto?

Comment 6

[Alberto Pastor [:albertopq]]

Sure, thanks!

Comment 7

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:1185765-landscape-rocketbar > mozilla-b2g:master

Comment 8

[Alberto Pastor [:albertopq]]

Comment on attachment 8640553 [details] [review]
[gaia] albertopq:1185765-landscape-rocketbar > mozilla-b2g:master

Not sure why, but the transform: translateY(0) to the statusbar makes the rocketbar (which is child node of the statusbar) think that the width is relative. Etienne, could you please take a look? Thanks!

Comment 9

[Etienne Segonzac (:etienne)]

Comment on attachment 8640553 [details] [review]
[gaia] albertopq:1185765-landscape-rocketbar > mozilla-b2g:master

Redirecting to Guillaume :)

Comment 10

[Guillaume Marty [:gmarty]]

Comment on attachment 8640553 [details] [review]
[gaia] albertopq:1185765-landscape-rocketbar > mozilla-b2g:master

LGTM. I like deletions only commits!

Comment 11

[Alberto Pastor [:albertopq]]

master: https://github.com/mozilla-b2g/gaia/commit/d3d61c53c62b797f68ab0cbbd281781581671a43

Comment 12

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest Aires KK 2.5 by the STR in comment 0.

Actual results: The Address/search bar covers the whole screen on landscape mode in Browser.
See attachment: verified_Aries_v2.5.png
Reproduce rate: 0/10


Device: Aries KK 2.5(Pass)
Build ID               20150803195455
Gaia Revision          dbacf8364f4505d021b7d8fb9cabea325004dbcc
Gaia Date              2015-08-03 16:38:49
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/abc56d57f6e1
Gecko Version          42.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150803.191800
Firmware Date          Mon Aug  3 19:18:08 UTC 2015
Bootloader             s1

Comment 13

[Shally Li（leave from Mozilla）]

Attachment: verified_Aries_v2.5.png