Make moz-extension:// protocol work on android

RESOLVED FIXED in Firefox 48

Status

()

Core
Networking
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Bobby Holley (parental leave - send mail for anything urgent), Assigned: mattw)

Tracking

(Blocks: 1 bug)

unspecified
mozilla48
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox48 fixed)

Details

(Whiteboard: [necko-backlog])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

It should work, but the tests from bug 1161831 time out, and I don't have the cycles to get a device and investigate. If someone with a device debugs this, I can walk you through what needs to be done.
Bill, can you mark this as blocking whatever bug tracks chrome-parity android addons?
Flags: needinfo?(wmccloskey)
Blocks: 1185785
Flags: needinfo?(wmccloskey)

Updated

2 years ago
Assignee: nobody → mwein
(Assignee)

Comment 2

2 years ago
Hey Bobby, I have a device and have time to investigate this.  Could you walk me through what needs to be done? My current IRC nick is mattw.
(In reply to Matthew Wein [:mattw] from comment #2)
> Hey Bobby, I have a device and have time to investigate this.  Could you
> walk me through what needs to be done? My current IRC nick is mattw.

Sure. The test is disabled because it timed out for some reason:

http://mxr.mozilla.org/mozilla-central/source/caps/tests/mochitest/mochitest.ini#13

Need to enable it and figure out what's going wrong.
(Assignee)

Comment 4

2 years ago
Okay, so I ran the test on my computer and it passed, and I also don't see that it's disabled. Should I be running the tests on an android device? If so, could you help me with that?
(In reply to Matthew Wein [:mattw] from comment #4)
> Okay, so I ran the test on my computer and it passed,

As desktop, or in an android emulator?

> and I also don't see that it's disabled.

It is disabled on android here: http://mxr.mozilla.org/mozilla-central/source/caps/tests/mochitest/mochitest.ini#14

> Should I be running the tests on an android device?

The first thing to do is probably to do an android try push and make sure it still fails. The test runners on treeherder are running emulators, so presumably the problem reproduces with emulators. I don't know what the current best practices for debugging android failures are, but I do know that various folks have recently made it at lot easier to build and debug emulator builds on Desktop. See https://lists.mozilla.org/pipermail/dev-platform/2015-November/012486.html and the associated screencast.

> If so, could you help me with that?

You probably want to talk to people with experience hacking on Firefox Android. #mobile is a good place to start.
(Assignee)

Updated

2 years ago
Iteration: --- → 47.2 - Feb 22
(Assignee)

Updated

2 years ago
Iteration: 47.2 - Feb 22 → ---
Whiteboard: [necko-backlog]
(Assignee)

Updated

2 years ago
Iteration: --- → 48.2 - Apr 4
(Assignee)

Comment 6

2 years ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=09ca64fda3d5
(Assignee)

Comment 7

2 years ago
Created attachment 8735626 [details]
MozReview Request: Bug 1185773 - Enable the moz-extension mochitest on android.

Review commit: https://reviewboard.mozilla.org/r/42881/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/42881/
(Assignee)

Updated

2 years ago
Keywords: checkin-needed
this needs review before checkin or ?
Flags: needinfo?(mwein)
(Assignee)

Updated

2 years ago
Flags: needinfo?(mwein)
Attachment #8735626 - Flags: review?(kmaglione+bmo)
(Assignee)

Comment 9

2 years ago
I didn't have to change any code to enable the tests so for some reason I didn't think to add a reviewer, but I'm still making a change to the mochitest.ini file so I'll add a reviewer now.
Keywords: checkin-needed
Comment on attachment 8735626 [details]
MozReview Request: Bug 1185773 - Enable the moz-extension mochitest on android.

https://reviewboard.mozilla.org/r/42881/#review39577

Can you change the commit summary to make it clear that this commit is actually only enabling tests?
Attachment #8735626 - Flags: review?(kmaglione+bmo) → review+
(Assignee)

Comment 11

2 years ago
Comment on attachment 8735626 [details]
MozReview Request: Bug 1185773 - Enable the moz-extension mochitest on android.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/42881/diff/1-2/
Attachment #8735626 - Attachment description: MozReview Request: Bug 1185773 - Make moz-extension:// protocol work on android. → MozReview Request: Bug 1185773 - Enable the moz-extension mochitest on android.
(Assignee)

Comment 12

2 years ago
The moz-extension:// protocol was fixed by Bug 1251042, so we only need to enable the test now.
(Assignee)

Updated

2 years ago
Keywords: checkin-needed
(In reply to Matthew Wein [:mattw] from comment #9)
> I didn't have to change any code to enable the tests so for some reason I
> didn't think to add a reviewer, but I'm still making a change to the
> mochitest.ini file so I'll add a reviewer now.

Anything being checked in needs a reviewer. The rare exceptions for trivial changes only apply if you're a peer and have access to check them in yourself.
(Assignee)

Comment 14

2 years ago
(In reply to Kris Maglione [:kmag] from comment #13)
> (In reply to Matthew Wein [:mattw] from comment #9)
> > I didn't have to change any code to enable the tests so for some reason I
> > didn't think to add a reviewer, but I'm still making a change to the
> > mochitest.ini file so I'll add a reviewer now.
> 
> Anything being checked in needs a reviewer. The rare exceptions for trivial
> changes only apply if you're a peer and have access to check them in
> yourself.

That makes sense, I think that's reasonable.

Comment 15

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/8a9823b951f6
Keywords: checkin-needed

Comment 16

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/8a9823b951f6
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.