1185773 - Make moz-extension:// protocol work on android

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Bobby Holley (:bholley)]

It should work, but the tests from bug 1161831 time out, and I don't have the cycles to get a device and investigate. If someone with a device debugs this, I can walk you through what needs to be done.

Comment 1

[Bobby Holley (:bholley)]

Bill, can you mark this as blocking whatever bug tracks chrome-parity android addons?

Comment 2

[Matthew Wein [:mattw]]

Hey Bobby, I have a device and have time to investigate this.  Could you walk me through what needs to be done? My current IRC nick is mattw.

Comment 3

[Bobby Holley (:bholley)]

(In reply to Matthew Wein [:mattw] from comment #2)
> Hey Bobby, I have a device and have time to investigate this.  Could you
> walk me through what needs to be done? My current IRC nick is mattw.

Sure. The test is disabled because it timed out for some reason:

http://mxr.mozilla.org/mozilla-central/source/caps/tests/mochitest/mochitest.ini#13

Need to enable it and figure out what's going wrong.

Comment 4

[Matthew Wein [:mattw]]

Okay, so I ran the test on my computer and it passed, and I also don't see that it's disabled. Should I be running the tests on an android device? If so, could you help me with that?

Comment 5

[Bobby Holley (:bholley)]

(In reply to Matthew Wein [:mattw] from comment #4)
> Okay, so I ran the test on my computer and it passed,

As desktop, or in an android emulator?

> and I also don't see that it's disabled.

It is disabled on android here: http://mxr.mozilla.org/mozilla-central/source/caps/tests/mochitest/mochitest.ini#14

> Should I be running the tests on an android device?

The first thing to do is probably to do an android try push and make sure it still fails. The test runners on treeherder are running emulators, so presumably the problem reproduces with emulators. I don't know what the current best practices for debugging android failures are, but I do know that various folks have recently made it at lot easier to build and debug emulator builds on Desktop. See https://lists.mozilla.org/pipermail/dev-platform/2015-November/012486.html and the associated screencast.

> If so, could you help me with that?

You probably want to talk to people with experience hacking on Firefox Android. #mobile is a good place to start.

Comment 6

[Matthew Wein [:mattw]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=09ca64fda3d5

Comment 7

[Matthew Wein [:mattw]]

Attachment: MozReview Request: Bug 1185773 - Enable the moz-extension mochitest on android.

Review commit: https://reviewboard.mozilla.org/r/42881/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/42881/

Comment 8

[Carsten Book [:Tomcat]]

this needs review before checkin or ?

Comment 9

[Matthew Wein [:mattw]]

I didn't have to change any code to enable the tests so for some reason I didn't think to add a reviewer, but I'm still making a change to the mochitest.ini file so I'll add a reviewer now.

Comment 10

[Kris Maglione [:kmag]]

Comment on attachment 8735626 [details]
MozReview Request: Bug 1185773 - Enable the moz-extension mochitest on android.

https://reviewboard.mozilla.org/r/42881/#review39577

Can you change the commit summary to make it clear that this commit is actually only enabling tests?

Comment 11

[Matthew Wein [:mattw]]

Comment on attachment 8735626 [details]
MozReview Request: Bug 1185773 - Enable the moz-extension mochitest on android.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/42881/diff/1-2/

Comment 12

[Matthew Wein [:mattw]]

The moz-extension:// protocol was fixed by Bug 1251042, so we only need to enable the test now.

Comment 13

[Kris Maglione [:kmag]]

(In reply to Matthew Wein [:mattw] from comment #9)
> I didn't have to change any code to enable the tests so for some reason I
> didn't think to add a reviewer, but I'm still making a change to the
> mochitest.ini file so I'll add a reviewer now.

Anything being checked in needs a reviewer. The rare exceptions for trivial changes only apply if you're a peer and have access to check them in yourself.

Comment 14

[Matthew Wein [:mattw]]

(In reply to Kris Maglione [:kmag] from comment #13)
> (In reply to Matthew Wein [:mattw] from comment #9)
> > I didn't have to change any code to enable the tests so for some reason I
> > didn't think to add a reviewer, but I'm still making a change to the
> > mochitest.ini file so I'll add a reviewer now.
> 
> Anything being checked in needs a reviewer. The rare exceptions for trivial
> changes only apply if you're a peer and have access to check them in
> yourself.

That makes sense, I think that's reasonable.

Comment 15

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8a9823b951f6

Comment 16

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8a9823b951f6