Closed Bug 1185803 Opened 5 years ago Closed 4 years ago

WebGL 2 - Remove MOZ_CRASH("Not Implemented.")

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: kamidphish, Assigned: kamidphish)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

These have outlived their usefulness and are causing conformance2 tests to crash the browser.  Replace with warning in the short term before real patches land.
Status: NEW → ASSIGNED
Comment on attachment 8636371 [details] [diff] [review]
Replace MOZ_CRASH with GenerateWarning.

Review of attachment 8636371 [details] [diff] [review]:
-----------------------------------------------------------------

Is it OK to crash the debug build and replace with MOZ_ASSERT or gfxCriticalError?  I'm worried about GenerateWarning being used for legitimate warnings already, and some of these being left around without causing enough pain to be handled.
Comment on attachment 8636371 [details] [diff] [review]
Replace MOZ_CRASH with GenerateWarning.

Review of attachment 8636371 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGL2ContextTextures.cpp
@@ +430,5 @@
>                               GLint xoffset, GLint yoffset, GLint zoffset,
>                               GLenum format, GLenum type, dom::ImageData* data,
>                               ErrorResult& rv)
>  {
> +    GenerateWarning("Not implemented.");

Include what function this is.
Attachment #8636371 - Flags: review?(jgilbert) → review+
(In reply to Milan Sreckovic [:milan] from comment #2)
> Comment on attachment 8636371 [details] [diff] [review]
> Replace MOZ_CRASH with GenerateWarning.
> 
> Review of attachment 8636371 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Is it OK to crash the debug build and replace with MOZ_ASSERT or
> gfxCriticalError?  I'm worried about GenerateWarning being used for
> legitimate warnings already, and some of these being left around without
> causing enough pain to be handled.

I think we're almost done having them at all, so let's just switch to GenerateWarning for now.
https://hg.mozilla.org/mozilla-central/rev/6713ac169edc
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.