1185803 - WebGL 2 - Remove MOZ_CRASH("Not Implemented.")

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[u480271]

These have outlived their usefulness and are causing conformance2 tests to crash the browser.  Replace with warning in the short term before real patches land.

Comment 1

[u480271]

Attachment: Replace MOZ_CRASH with GenerateWarning.

Comment 2

[Milan Sreckovic [:milan] (needinfo for best results)]

Comment on attachment 8636371 [details] [diff] [review]
Replace MOZ_CRASH with GenerateWarning.

Review of attachment 8636371 [details] [diff] [review]:
-----------------------------------------------------------------

Is it OK to crash the debug build and replace with MOZ_ASSERT or gfxCriticalError?  I'm worried about GenerateWarning being used for legitimate warnings already, and some of these being left around without causing enough pain to be handled.

Comment 3

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8636371 [details] [diff] [review]
Replace MOZ_CRASH with GenerateWarning.

Review of attachment 8636371 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGL2ContextTextures.cpp
@@ +430,5 @@
>                               GLint xoffset, GLint yoffset, GLint zoffset,
>                               GLenum format, GLenum type, dom::ImageData* data,
>                               ErrorResult& rv)
>  {
> +    GenerateWarning("Not implemented.");

Include what function this is.

Comment 4

[Kelsey Gilbert [:jgilbert]]

(In reply to Milan Sreckovic [:milan] from comment #2)
> Comment on attachment 8636371 [details] [diff] [review]
> Replace MOZ_CRASH with GenerateWarning.
> 
> Review of attachment 8636371 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Is it OK to crash the debug build and replace with MOZ_ASSERT or
> gfxCriticalError?  I'm worried about GenerateWarning being used for
> legitimate warnings already, and some of these being left around without
> causing enough pain to be handled.

I think we're almost done having them at all, so let's just switch to GenerateWarning for now.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6713ac169edc

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6713ac169edc