Closed Bug 1185815 Opened 5 years ago Closed 5 years ago

WebGL 2 - gl.getBufferSubData fails on gl.TRANSFORM_FEEDBACK_BUFFER

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: djg, Assigned: djg)

References

()

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

FAIL getError expected: NO_ERROR. Was INVALID_OPERATION : gl.getBufferSubData(TRANSFORM_FEEDBACK_BUFFER, 0, retBuffer) should work
Comment on attachment 8636404 [details] [diff] [review]
Hoist generation increment so WebGL objects are in the same generation.

Review of attachment 8636404 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for leaving a comment there, too.

::: dom/canvas/WebGLContext.cpp
@@ +902,5 @@
>      }
>  
> +    // increment the generation number - Do this early because later
> +    // in CreateOffscreenGL(), "default" objects are created that will
> +    // pick up the old generation.

Interesting!
Attachment #8636404 - Flags: review?(jgilbert) → review+
https://hg.mozilla.org/mozilla-central/rev/5141f9fd3b4e
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.