1185853 - Disabling ADB does not work in developer mode

Status: RESOLVED DUPLICATE of bug 1182952

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Thomas Daede [:TD-Linux]]

There is a setting to select enabling or disabling ADB in the Developer menu, however it has no effect when the foxfood build has been reflashed into developer mode (something which I assume basically 100% of foxfooders have done, as it's required to use some of the preinstalled apps and get all of the foxfooding achievements).

Comment 1

[Michal Purzynski [:michal`] (use NEEDINFO)]

See also (for rationale) - https://bugzilla.mozilla.org/show_bug.cgi?id=842747#c8

Comment 2

[Dave Hylands [:dhylands]]

Currently, we force adb on all of the time when marionette is enabled (i.e. eng and userdebug builds).

Currently, the setting in the UI is only looked at for user builds.

This is implemented here:
https://dxr.mozilla.org/mozilla-central/source/b2g/chrome/content/devtools/adb.js?from=adb.js#168-181

Our automated tests need adb, so if the default setting would be to have adb enabled for eng & userdebug builds, then we might be able to remove the override.

I don't believe that we currently have any UI to select between adb always on (which is certainly what I prefer for developing) and having adb only be on when the screen is locked (which is what michal wants)

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Can you CC me on bug 1182952 so I can view it?

Comment 5

[Dave Hylands [:dhylands]]

(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #4)
> Can you CC me on bug 1182952 so I can view it?

Done

Comment 6

[Michal Purzynski [:michal`] (use NEEDINFO)]

Can you CC me on bug 1182952 so I can view it?

Comment 7

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

(In reply to Michal Purzynski [:michal`] (use NEEDINFO) from comment #6)
> Can you CC me on bug 1182952 so I can view it?

done.