1185889 - [Windows 10] Close tab icon is incorrectly displayed for DevEdition Theme on Nightly

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Cornel Ionce [:noni] [Hubs QA]]

Mozilla/5.0 (Windows NT 10.0; WOW64; rv:42.0) Gecko/20100101 Firefox/42.0
Build ID: 20150720030213

STR:
1. Open Nightly using a clean profile.
2. Go to abount:addons -> Appearance tab.
3. Enable the "Developer Edition" theme.

Expected Results:
The Developer Edition theme is properly enabled, there should be no UI issues.

Actual Results:
The close tab (X) button is very big and just partially displayed.

Screenshot: http://i.imgur.com/35d7CPl.png

Notes:
1. This issue is a recent regression.
2. The icon is blurry on a regular display (not blurry on HiDPI).
3. The icon is displayed at the normal size when hovered.


Regression Range:
Last-good buildID: 20150717030202
First-bad buildID: 20150718030211
Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=15155971639c&tochange=d317a93e5161

Comment 2

[Justin Dolske [:Dolske]]

The larger icon is expected from bug 1173729, but it being cut-off is not. Might be worth considering if devtools should use a different shape, though... The round icon seems a little out of place with the square tabs.

Comment 3

[Tim Nguyen :ntim]

Attachment: Patch

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/08cf05d407fc

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/08cf05d407fc

Comment 6

[Tim Nguyen :ntim]

Comment on attachment 8637237 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: bug 1173729
[User impact if declined]: Broken close button look
[Describe test coverage new/current, TreeHerder]: on m-c, tested locally
[Risks and why]: low, straightforward css fix
[String/UUID change made/needed]: none

Comment 7

[Lawrence Mandel [:lmandel] (use needinfo)]

If this is only an issue on Dev Edition, do we need the fix in 40 and 41 as we will first support Windows 10 when Firefox 40 releases and Dev Edition is 42?

Comment 8

[Tim Nguyen :ntim]

(In reply to Lawrence Mandel [:lmandel] (use needinfo) from comment #7)
> If this is only an issue on Dev Edition, do we need the fix in 40 and 41 as
> we will first support Windows 10 when Firefox 40 releases and Dev Edition is
> 42?
The issue is on the devedition theme alltogether.
But since that theme can't be enabled on Beta, it's fine not to uplift this fix there. (see bug 1181721).

Comment 9

[Brian Grinstead [:bgrins]]

(In reply to Lawrence Mandel [:lmandel] (use needinfo) from comment #7)
> If this is only an issue on Dev Edition, do we need the fix in 40 and 41 as
> we will first support Windows 10 when Firefox 40 releases and Dev Edition is
> 42?

We are hoping that Win 10 Dev Edition theme will be ready in 41 / the initial release of Win 10.  There are just a few bugs that will need uplift to make that possible (this one included).  No need to push this to beta though.

Comment 10

[Cornel Ionce [:noni] [Hubs QA]]

As of today (2015-07-23), I'm also seeing this on DevEdition. We should uplift this fix to 41 as soon as possible.

Verified fixed on latest Nightly (build ID: 20150723030207).

Comment 11

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8637237 [details] [diff] [review]
Patch

Fix was verified on nightly, let's uplift to Aurora.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/89cf1f6f99cb

Comment 14

[Tim Nguyen :ntim]

Comment on attachment 8637237 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: Windows 10
[User impact if declined]: None, but eases up future fixes to be uplifted
[Describe test coverage new/current, TreeHerder]: baked on m-c and aurora, QA verified the fix on Nightly
[Risks and why]: Low, CSS only fix with no issues found so far
[String/UUID change made/needed]: none

Comment 16

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8637237 [details] [diff] [review]
Patch

We're building our final beta tomorrow and will no longer take nice to have or speculative fixes. Unless this is a prereq for one of the Windows 10 related fixes that we're taking in beta9, it will need to wait for 41. Beta-

Comment 18

[Rezaul Huque Nayeem]

I have successfully reproduced this bug on Firefox nightly 42.0a1 (2015-07-21)

I found this fix on latest Firefox aurora 41.0a2 (2015-07-31)

Build ID : 20150731004008
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:41.0) Gecko/20100101 Firefox/41.0

[bugday-20150729]

Comment 19

[Cornel Ionce [:noni] [Hubs QA]]

Mozilla/5.0 (Windows NT 10.0; WOW64; rv:41.0) Gecko/20100101 Firefox/41.0

Confirming this fix for latest 41.0a2 Aurora, build ID: 20150802004005

Comment 21

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Untracked bug 1187568, adding a tracking flag here instead to be safe.