1185958 - Windows 10: Only show box-shadow of location bar and search field on focus

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P3)

Description

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

After working with it for a while, we should only have the 2px outline of the location bar and search field when it is focused.

This can be done by simply removing this line:
https://dxr.mozilla.org/mozilla-central/source/browser/themes/windows/browser.css#1229

Comment 1

[Justin Dolske [:Dolske]]

I think this will also make the hover-outline thickness consistent with the outline on toolbar buttons.

Comment 2

[Dão Gottwald [:dao]]

Attachment: patch

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/b787fd6ee92b

Comment 4

[Ryan VanderMeulen (PTO, back July 27)]

https://hg.mozilla.org/mozilla-central/rev/b787fd6ee92b

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 8637172 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: bug 1185944 / windows 10
[User impact if declined]: aesthetics
[Describe test coverage new/current, TreeHerder]: n/a
[Risks and why]: most trivial patch
[String/UUID change made/needed]: none

Comment 6

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8637172 [details] [diff] [review]
patch

Trivial style correction. Beta+ Aurora+

Comment 7

[Ryan VanderMeulen (PTO, back July 27)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5d192e4993c0

Comment 8

[Ryan VanderMeulen (PTO, back July 27)]

https://hg.mozilla.org/releases/mozilla-beta/rev/7f005a3c9f9d

Comment 9

[Cornel Ionce [:noni]]

Verified this fix on Windows 10 64-bit using regular and HiDPI displays with:
- latest Nightly, build ID: 20150723030207;
- latest Aurora, build ID: 20150723004007;
- Firefox 40 beta 7, build ID: 20150720220238.