Closed Bug 1185958 Opened 8 years ago Closed 8 years ago

Windows 10: Only show box-shadow of location bar and search field on focus

Categories

(Firefox :: Theme, defect, P3)

Product:
Firefox
Component:
Theme
Version:
40 Branch
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 42
Tracking Flags:
Tracking Status
firefox39 --- unaffected
firefox40 --- verified
firefox41 --- verified
firefox42 --- verified

People

(Reporter: phlsa, Assigned: dao)

References

Details

Attachments

(1 file)

patch
669 bytes, patch
jaws
: review+
lmandel
: approval-mozilla-aurora+
lmandel
: approval-mozilla-beta+
Details | Diff | Splinter Review 
After working with it for a while, we should only have the 2px outline of the location bar and search field when it is focused.

This can be done by simply removing this line:
https://dxr.mozilla.org/mozilla-central/source/browser/themes/windows/browser.css#1229
I think this will also make the hover-outline thickness consistent with the outline on toolbar buttons.
Priority: -- → P3
Attached patch patch — — Splinter Review 
Assignee: nobody → dao
Status: NEW → ASSIGNED

        Attachment #8637172 -
        Flags: review?(jaws)

        Attachment #8637172 -
        Flags: review?(jaws) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/b787fd6ee92b
Status: ASSIGNED → RESOLVED
Closed: 8 years ago

          status-firefox42:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42

    
    

    
  
Comment on attachment 8637172 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: bug 1185944 / windows 10
[User impact if declined]: aesthetics
[Describe test coverage new/current, TreeHerder]: n/a
[Risks and why]: most trivial patch
[String/UUID change made/needed]: none

        Attachment #8637172 -
        Flags: approval-mozilla-beta?

        Attachment #8637172 -
        Flags: approval-mozilla-aurora?

    
    

    
  
Comment on attachment 8637172 [details] [diff] [review]
patch

Trivial style correction. Beta+ Aurora+

        Attachment #8637172 -
        Flags: approval-mozilla-beta?

        Attachment #8637172 -
        Flags: approval-mozilla-beta+

        Attachment #8637172 -
        Flags: approval-mozilla-aurora?

        Attachment #8637172 -
        Flags: approval-mozilla-aurora+
Flags: qe-verify+
QA Contact: cornel.ionce

    
    

    
  
Verified this fix on Windows 10 64-bit using regular and HiDPI displays with:
- latest Nightly, build ID: 20150723030207;
- latest Aurora, build ID: 20150723004007;
- Firefox 40 beta 7, build ID: 20150720220238.
Status: RESOLVED → VERIFIED

          status-firefox40:
          fixed → verified

          status-firefox41:
          fixed → verified

          status-firefox42:
          fixed → verified

          You need to log in
          before you can comment on or make changes to this bug.