Closed Bug 1185983 Opened 5 years ago Closed 5 years ago

[Messages] Focus handling is messy when entering Conversation or NewMessage views

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: julienw, Assigned: julienw)

References

Details

(Whiteboard: [sms-FxOS-S3])

Attachments

(1 file)

No description provided.
Assignee: nobody → felash
Whiteboard: [sms-FxOS-S3]
Comment on attachment 8636663 [details] [review]
[gaia] julienw:1185983-refactor-focus-handling > mozilla-b2g:master

Tell me what you think ! I added some comments on github to help reading the patch.

The focus handling in the Recipients panel is quite messy as well but I think this is out of the scope of this patch and could be a separate patch by itself.
Attachment #8636663 - Flags: review?(azasypkin)
Comment on attachment 8636663 [details] [review]
[gaia] julienw:1185983-refactor-focus-handling > mozilla-b2g:master

Looks really nice! But it seems one case is missed - when we open conversation with draft from Inbox view or notification, message input is focused on master, but not with the patch.

Would be great to have tiny integration test for this case if possible, but won't block on this :)

Thanks!
Attachment #8636663 - Flags: review?(azasypkin)
Comment on attachment 8636663 [details] [review]
[gaia] julienw:1185983-refactor-focus-handling > mozilla-b2g:master

Hey,

I think I covered your comments now, it's all in a separate commit :)
Tell me what you think :)
Attachment #8636663 - Flags: review?(azasypkin)
Comment on attachment 8636663 [details] [review]
[gaia] julienw:1185983-refactor-focus-handling > mozilla-b2g:master

Can't find any issues now, looks good!

Please, make sure that new "number" activity case works as well :) I could not test it because of startup crash in Contacts app (bug 1186920) for all my Flames.

Thanks!
Attachment #8636663 - Flags: review?(azasypkin) → review+
master: 73ab548325594b629a46b2eb846981fa75296bda

thanks !
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.