42 bytes, text/x-github-pull-request
|Details | Review | Splinter Review|
The `utils.get_user_data` function was attempting to look for users that were not in Master_Subscribers, but were in Double_Opt_In in the Confirmation data extension using whatever info was passed to the function. When the lookup was via email, the email address was used, but the Confirmation extension does not have an EMAIL_ADDRESS_ column. This caused errors for all of these users and basket was returning a 400 error. The expected behavior is for basket to return a 200 response indicating that the user was found, but unconfirmed.
Created attachment 8636580 [details] [review] Link to Github pull-request: https://github.com/mozilla/basket/pull/139
Pmac - re: "that were not in Master_Subscribers, but were in Double_Opt_In in the Confirmation data extension using whatever info was passed to the function." Just expanding my knowledge: When/how/why would Basket look up someone in the "Confirmation" table instead of the "Double_Opt_In" table?
basket looks in the following order: Master_Subscribers (MS), Double_Opt_In, Confirmation. The following pseudo-code will hopefully make it more clear: if user is in Master_Subscribers: return user otherwise if user is in Double_Opt_In: # now we check in Confirmation because user was NOT in MS if user is in Confirmation: user is confirmed and awaiting the move to MS otherwise: user has not clicked on the confirmation email otherwise: there is no user
Niice - thanks!
Commits pushed to master at https://github.com/mozilla/basket https://github.com/mozilla/basket/commit/c5b18e2d526606c1799291df3d1e6170bf3b3ac0 Fix bug 1185999: Look up users in Confirmed DE properly. https://github.com/mozilla/basket/commit/034a156c3f87ec5b8efa98f6f781b4959786adc2 Merge pull request #139 from pmclanahan/fix-look-for-user-1185999 Fix bug 1185999: Look up users in Confirmed DE properly.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.