1186008 - [Shinano] Fix devices naming

Status: RESOLVED FIXED

(Firefox OS Graveyard :: GonkIntegration, defect)

Description

[:gerard-majax]

We should stop naming the device 'shinano' because that is the name of the platform. We are using this name on lollipop also which makes the Z3 device not buildable because all the Sony bits expects 'leo' and not 'shinano'.

The plan is to:
 - kill the old 'leo' (LG Fireweb) device since it's deprecated and not used anymore
 - update docs (MDN/intranet)
 - rename 'shinano'/'shinano-l' device (PRODUCT_NAME) to 'leo-kk' and 'leo-l' depending on the port
 - rename 'aries'/'aries-l' device (PRODUCT_NAME) to 'aries-kk' and 'aries-l'

I think we should keep the 'shinano', 'shinano-l' and 'aries' entries in config.sh for backward compability, but make sure we set the proper PRODUCT_NAME.

Comment 1

[:gerard-majax]

What will be the impact for currently used devices ? Those will be impacted by the renaming of 'aries' to 'aries-kk'.

Comment 2

[[e-mail] (:bhearsum)]

Deferring to Wander, he's doing some work in this area already.

Comment 3

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I would prefer not to change at all.  Esp because I'm already busy with things + I need to figure out when I can test things.

If we are to change:
1) Not too sure if contributors are building for Leo ( LG Fireweb )since they couldn't figure out how to root it.
2) I would prefer to rename LG leo rather than delete it.  If we're going to seriously delete it then we should delete all the other ones like Otoro, Unagi, etc.
3) At the same time, I think it might be best to name it something like LG-Leo and Sony-Leo; I have a feeling that there's going to be multiple Leos.

Aries-kk, pvtbuild, task cluster + the update server has to end up changing as well as automation. The getting people (QA + dogfooders) to be aware of this, and the new location.   The cost of this change will cause a lot of breakage all around, and confusion.  This is based on the size change for flame.

Comment 4

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Note: the system size for flame was needed for OTA.

This change is not necessarily needed.  It was a bad choice of names and if we're already keeping the shinano for backwards compatibility, why are we changing it now?

Comment 5

[:gerard-majax]

(In reply to Naoki Hirata :nhirata (please use needinfo instead of cc) from comment #4)
> Note: the system size for flame was needed for OTA.
> 
> This change is not necessarily needed.  It was a bad choice of names and if
> we're already keeping the shinano for backwards compatibility, why are we
> changing it now?

When I'm speaking of compatibility, I'm just referring to the config.sh argument.

(In reply to Naoki Hirata :nhirata (please use needinfo instead of cc) from comment #3)
> I would prefer not to change at all.  Esp because I'm already busy with
> things + I need to figure out when I can test things.
> 
> If we are to change:
> 1) Not too sure if contributors are building for Leo ( LG Fireweb )since
> they couldn't figure out how to root it.
> 2) I would prefer to rename LG leo rather than delete it.  If we're going to
> seriously delete it then we should delete all the other ones like Otoro,
> Unagi, etc.
> 3) At the same time, I think it might be best to name it something like
> LG-Leo and Sony-Leo; I have a feeling that there's going to be multiple Leos.
> 
> Aries-kk, pvtbuild, task cluster + the update server has to end up changing
> as well as automation. The getting people (QA + dogfooders) to be aware of
> this, and the new location.   The cost of this change will cause a lot of
> breakage all around, and confusion.  This is based on the size change for
> flame.

Yeah that was the kind of thing I was fearing about. I have just re-read the email reply from Michael about this, and I don't know where the idea to rename aries came from, but it's not there. So I'll just hack on Z3, but do not touch Z3 Compact.

Comment 6

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Should we won't fix this then?  Or do you have a different proposal?

Comment 7

[:gerard-majax]

No, we really need to fix the Z3.

Comment 8

[:gerard-majax]

Attachment: Manifest PR

Michael, this does not include any change on the naming of KK repo and device directory for Z3, which I'm sure we do want.

So for KK, should I:
 - just rename the device/sony/shinano to device/sony/leo and keep the repo name as device-shinano on the mozilla-b2g github account
 - or should we also rename the device-shinano to device-leo (and thus delete the LG device) ?

Comment 9

[:gerard-majax]

Attachment: B2G PR

Removing references to the old leo LG device, renaming shinano to leo-kk and shinano-l to leo-l.

Comment 10

[:gerard-majax]

Attachment: Sony Leo device PR

Renaming the L device

Comment 11

[:gerard-majax]

Attachment: Sony Leo device KK PR

And now the KK device counterpart.

Comment 12

[:gerard-majax]

Kevin, I know you have such a device so you might want to be aware. Would be awesome if you have some time to cross check on your side that everything is good :).

Comment 13

[Michael Wu [:mwu]]

(In reply to Alexandre LISSY :gerard-majax from comment #8)
> Created attachment 8637076 [details] [review]
> Manifest PR
> 
> Michael, this does not include any change on the naming of KK repo and
> device directory for Z3, which I'm sure we do want.
> 
> So for KK, should I:
>  - just rename the device/sony/shinano to device/sony/leo and keep the repo
> name as device-shinano on the mozilla-b2g github account
>  - or should we also rename the device-shinano to device-leo (and thus
> delete the LG device) ?

Isn't there a device-sony-leo we can use?

Just keeping the repo name as device-shinano is also fine. I don't care too much about the details here if we're going to be focusing on the l port.

Comment 14

[:gerard-majax]

The device-sony-leo is from the fork from Sony's repo. While we could push to a dedicated branch, I think it may lead to more confusion than anything else.

Comment 15

[Michael Wu [:mwu]]

Ok

Comment 16

[:gerard-majax]

https://github.com/mozilla-b2g/b2g-manifest/commit/aa686b5c21d59f7c9d45ed07da17dabc25e71258
https://github.com/mozilla-b2g/B2G/commit/d8d15e905dfedb8d0147abab76df44dabfd83e1b
https://github.com/mozilla-b2g/device-sony-leo/commit/cf260f04ea8665d5cd77836a2ab8440f2613f92f
https://github.com/mozilla-b2g/device-shinano/commit/653f7e1f093b948e40262fcb3c665c2b4976df74

Comment 17

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

FYI wander, there might be some fall outs from this?  Not sure.  Hopefully the new name will not cause issues....

Peter, Kevin, please keep an eye out to make sure we have working aries build tomorrow.

Comment 18

[Wander Lairson Costa]

Sorry for the late response. aries.xml is a sym link to shinano.xml in the b2g-manifest repo. As shinano is still there, we should be fine.

I am working on unique device names for OTA things, but it is unrelated to this.

Comment 19

[Kevin Grandon :kgrandon]

(In reply to Alexandre LISSY :gerard-majax from comment #12)
> Kevin, I know you have such a device so you might want to be aware. Would be
> awesome if you have some time to cross check on your side that everything is
> good :).

I can try. So I should re-build, with 'leo-l'?

Comment 20

[:gerard-majax]

(In reply to Kevin Grandon :kgrandon from comment #19)
> (In reply to Alexandre LISSY :gerard-majax from comment #12)
> > Kevin, I know you have such a device so you might want to be aware. Would be
> > awesome if you have some time to cross check on your side that everything is
> > good :).
> 
> I can try. So I should re-build, with 'leo-l'?

Kevin, I think you probably have a KK build right now. Check your .config in your build tree. If you have "shinano", then pull to update your B2G/ tree and then |./config.sh leo-kk|. If you have "shinano-l", you'll need to |./config.sh leo-l|.

Comment 21

[Kevin Grandon :kgrandon]

Still on my radar to test, I think I need the appropriate backup directory. Will follow-up on that.

Comment 22

[Peter Bylenga [:PBylenga]]

clearing NI, didn't see anything abnormal on Aries

Comment 23

[Kevin Grandon :kgrandon]

(In reply to Alexandre LISSY :gerard-majax from comment #12)
> Kevin, I know you have such a device so you might want to be aware. Would be
> awesome if you have some time to cross check on your side that everything is
> good :).

Been dogfooding for today with this (leo-kk build) so far and nothing that seems off. Will report back if I find anything. Thanks for doing this work!