Double quotes in firefox-ios strings file breaks the build

RESOLVED FIXED

Status

--
critical
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: rnewman, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

3 years ago
This is breaking CI builds:

Error in firefox-ios/Client/de.lproj/Intro.strings
Copy .strings file Error: Read failed: The data couldn’t be read because it isn’t in the correct format.


Seems to be just the same as Bug 1182799 and Bug 1140751. There are strings like:

        <target>Die Schaltfläche "Einstellungen" befindet sich am Anfang der Tab-Ablage.</target>


Those straight double quotes aren't handled correctly by the build, so we need to avoid them.

(I'd drive-by fix these myself, switching to a nice non-ASCII glyph like curly quotes, but I don't know the correct quoting style for German.)
Hi Coce, normal double quotes must not be used. Please alter the texts.
Flags: needinfo?(coce)
Thanks, things might get better after r143490.
Flags: needinfo?(coce)
(Reporter)

Comment 3

3 years ago
Thanks for the quick fixes, folks, and sorry for the churn!
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Thanks to flod who fixed two more double quotes.
You need to log in before you can comment on or make changes to this bug.