Closed Bug 1186062 Opened 9 years ago Closed 9 years ago

newtab-customize-panel doesn't have rounded edges

Categories

(Firefox :: New Tab Page, defect)

Product:
Firefox
Component:
New Tab Page
Version:
42 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 42
Tracking Flags:
Tracking Status
firefox42 --- verified

People

(Reporter: ursula, Assigned: ursula)

Details

Attachments

(1 file, 3 obsolete files)

newtab-customize-panel doesn't have rounded edges
3.52 KB, patch
ursula
: review+
Details | Diff | Splinter Review 
When converting the newtab-customize-panel into an HTML element (see bug 1168589), the bottom corners were left unrounded by removing the "overflow: hidden" attribute.
Assignee: nobody → ursulasarracini
Comment on attachment 8636672 [details] [diff] [review]
newtab-customize-panel doesn't have rounded edges

Adding overflow:hidden hides the anchor, so I added a border radius to the last element in the panel. Is that ok?
Attachment #8636672 - Flags: review?(mstange)
Can we add another wrapper element that we set the border-radius and overflow:hidden on, and then have the arrow outside that wrapper?
Attachment #8636672 - Attachment is obsolete: true
Attachment #8636672 - Flags: review?(mstange)
Attachment #8636677 - Flags: review?(mstange)
Comment on attachment 8636677 [details] [diff] [review]
newtab-customize-panel doesn't have rounded edges

Review of attachment 8636677 [details] [diff] [review]:
-----------------------------------------------------------------

I think you should also move the background to #newtab-customize-panel-inner-wrapper, and remove both the background and the border-radius from the outer wrapper.
Attachment #8636677 - Attachment is obsolete: true
Attachment #8636677 - Flags: review?(mstange)
Attachment #8636680 - Flags: review?(mstange)
Attachment #8636680 - Flags: review?(mstange) → review+
Hey Ursula - I'm afraid this patch doesn't apply cleanly. :/ Can you rebase it on top of a more recent tip of mozilla-central?
Flags: needinfo?(ursulasarracini)
Attachment #8636680 - Attachment is obsolete: true
Pulled from fx-team and rebased on top, should be good to go now!
Flags: needinfo?(ursulasarracini)
Comment on attachment 8636834 [details] [diff] [review]
newtab-customize-panel doesn't have rounded edges

Carrying forward r+ from mstange
Attachment #8636834 - Flags: review+
url:        https://hg.mozilla.org/integration/fx-team/rev/01c6880aed35e4a4098ff94ccce691f7fceed2d6
changeset:  01c6880aed35e4a4098ff94ccce691f7fceed2d6
user:       Ursula <usarracini@mozilla.com>
date:       Tue Jul 21 13:48:16 2015 -0400
description:
Bug 1186062 - newtab-customize-panel doesn't have rounded edges. r=mstange.
https://hg.mozilla.org/mozilla-central/rev/01c6880aed35
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox42: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
I looked for new tab-customize-panel into an HTML element and reproduce that 'Customize New Tab Page' pane haven't rounded edges.Found on Firefox nightly windows 8.1(32bit) 

Build ID 	20150721030212
User Agent 	Mozilla/5.0 (Windows NT 6.3; rv:42.0) Gecko/20100101 Firefox/42.0


It's all right on Latest Nightly..

Build ID 	20150724030210
User Agent 	Mozilla/5.0 (Windows NT 6.3; rv:42.0) Gecko/20100101 Firefox/42.0

[bugday-20150724]
Reproduced this issue on 02015-08-02 Aurora build.

Confirming the fix for latest Nightly, build ID: 20150802030218, across platforms.
Status: RESOLVED → VERIFIED
status-firefox42: fixed → verified
Flags: qe-verify+
QA Contact: cornel.ionce
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: