1186134 - Make the NewTab Page display manifest icons if available

Status: RESOLVED WONTFIX

(Firefox :: New Tab Page, defect)

Description

[Olivier Yiptong [:oyiptong]]

This bug is to track the integration of webmanifest in the newtab page.

That includes changes in sites.js's captureIfMissing: https://dxr.mozilla.org/mozilla-central/source/browser/base/content/newtab/sites.js#218

And NewTabUtils.jsm's PlacesProvider.getLinks function to add additional metadata, e.g. bg-color: https://dxr.mozilla.org/mozilla-central/source/toolkit/modules/NewTabUtils.jsm#645

Comment 1

[Olivier Yiptong [:oyiptong]]

bg-color may actually not be necessary if we render the tile in a canvas and cache in PageThumbs

Comment 2

[Marcos Caceres [:marcosc]]

(In reply to Olivier Yiptong [:oyiptong] from comment #1)
> bg-color may actually not be necessary if we render the tile in a canvas and
> cache in PageThumbs

Can you provide a bit more detail about what you are thinking here about not needing the bg-color? The problem I'm running into is that most people make icons either square or circular (transparent), but the tiles are rectangles.

Comment 3

[Olivier Yiptong [:oyiptong]]

I was thinking we might not need to inject the bg-color in NewTabUtil's PlacesProvider if we render an image.

The bg-color property will still be needed for rendering the image.