Move the PersistentRooted list heads into RootLists

RESOLVED FIXED in Firefox 42

Status

()

Core
JavaScript: GC
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: terrence, Assigned: terrence)

Tracking

Trunk
mozilla42
Points:
---

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8636755 [details] [diff] [review]
1_move_persistentrooted_to_rootlists-v0.diff

This seems conceptually cleaner than having them on the per-thread-data separately. The only issue is making sure that the root doesn't live longer than the container that registers it. Generally this just means we need to use the runtime instead of the context when registering system roots.
Attachment #8636755 - Flags: review?(sphink)
Comment on attachment 8636755 [details] [diff] [review]
1_move_persistentrooted_to_rootlists-v0.diff

Review of attachment 8636755 [details] [diff] [review]:
-----------------------------------------------------------------

I'm bad. I didn't check whether there are any other cx users that needed to be switched to rt.
Attachment #8636755 - Flags: review?(sphink) → review+
https://hg.mozilla.org/mozilla-central/rev/78d7e9528234
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox42: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.