1186174 - Enable region specific search defaults for all Fennec users

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Florian Quèze [:florian]]

Attachment: Patch

(Mark Finkle (:mfinkle) from bug 1175218 comment #34)
> Looks like this broke geo specific defaults on Fennec. The default for US
> should be "Yahoo" but is "Google".

This is because there are two mobile-l10n.js files, and for multi-locales builds, the one uses is the one in the installer/ folder which we didn't modify in bug 1175218. I think rather than enabling for all locales on multi-locale builds + en-US builds (which kinda covers all the possible cases) it makes more sense to just enable in mobile.js for all Fennec builds.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8636772 [details] [diff] [review]
Patch

We'll need some testing to know that non-US clients are correctly getting Google.

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/9f71fd7e13f9

Comment 3

[Florian Quèze [:florian]]

Comment on attachment 8636772 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: bug 1175218
[User impact if declined]: Google set as the default on Fennec in the US.
[Describe test coverage new/current, TreeHerder]: none.
[Risks and why]: low, the patch just changes prefs to enable the feature for all locales.
[String/UUID change made/needed]: none.

Comment 4

[Mike Connor [:mconnor]]

This was tested quickly by sebastian on #mobile, worked as expected.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9f71fd7e13f9

Comment 6

[Lawrence Mandel [:lmandel] (use needinfo)]

Florian - I assume this will need to be uplifted to Beta as well in order to take bug 1175218 on Beta. Can you please confirm?

Comment 7

[Lawrence Mandel [:lmandel] (use needinfo)]

Tracking 40 and 41 as we can't ship with this bug.

Comment 8

[Florian Quèze [:florian]]

(In reply to Lawrence Mandel [:lmandel] (use needinfo) from comment #6)
> Florian - I assume this will need to be uplifted to Beta as well in order to
> take bug 1175218 on Beta. Can you please confirm?

Yes. I was assuming I would just fold this patch into the beta patch from bug 1175218, but if you prefer us to uplift this as a separate changeset on the beta repository, that's fine with me too.

Comment 9

[Lawrence Mandel [:lmandel] (use needinfo)]

(In reply to Florian Quèze [:florian] [:flo] (PTO until August 3rd) from comment #8)
> Yes. I was assuming I would just fold this patch into the beta patch from
> bug 1175218, but if you prefer us to uplift this as a separate changeset on
> the beta repository, that's fine with me too.

I don't have a preference. Either way is fine for me.

Comment 10

[Lawrence Mandel [:lmandel] (use needinfo)]

Florian is going to roll this fix into his patch on bug 1175218 for 40. Clearing tracking and marking 40 as unaffected.

Comment 11

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8636772 [details] [diff] [review]
Patch

Given that this fix has already been tested, let's get this on Aurora asap. Aurora+

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/9a017f01afea