1186209 - enumerateDevices doesn't return if no devices are found

Status: VERIFIED FIXED

(Core :: WebRTC, defect, P1)

Description

[Mark Banner (:standard8)]

STR

1) Set up a Windows VM with no audio nor video devices
2) Start up Firefox, open the Browser Console.
3) Enter:

navigator.mediaDevices.enumerateDevices().then(function(result) { console.log(result) }).catch(function() { console.log("fail"); })

Expected Results (as shown in FF 39 release & FF 40.0b6 versions):

  Promise { <state>: "pending" }
  "fail"

Actual Results (as shown in nightly, 42.0a1, and aurora, 41.0a1):

  Promise { <state>: "pending" }

- no fail line is shown in nightly/aurora.

The result is returned fine if devices are present.

Comment 1

[Mark Banner (:standard8)]

[Tracking Requested - why for this release]: Regression in the WebRTC platform API - Hello also uses this functionality (this was discovered in the verification testing of bug 1168333).

Comment 2

[Mike de Boer [:mikedeboer]]

Some way to test this functionality for regressions in the future would also be nice!

Comment 3

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Thanks, I see what's going on.

Comment 4

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: MozReview Request: Bug 1186209 - check for VTYPE_EMPTY_ARRAY in enumerateDevices + test.

Bug 1186209 - check for VTYPE_EMPTY_ARRAY in enumerateDevices + test.

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8637323 [details]
MozReview Request: Bug 1186209 - check for VTYPE_EMPTY_ARRAY in enumerateDevices + test.

https://reviewboard.mozilla.org/r/13835/#review12491

Ship It!

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6f0d5f96cae6

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6f0d5f96cae6

Comment 9

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Tracked. Randell, do you want to request uplift to m-a? Thanks!

Comment 10

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8637323 [details]
MozReview Request: Bug 1186209 - check for VTYPE_EMPTY_ARRAY in enumerateDevices + test.

Approval Request Comment
[Feature/regressing bug #]: Bug 1169665
[User impact if declined]:

Calls to navigator.mediaDevices.enumerateDevices() will never resolve on systems with no camera or microphone.

[Describe test coverage new/current, TreeHerder]:

Landed on m-c with proper test of simulated zero devices this time.

[Risks and why]:

Very low, because this was a simple trip-up of not handling VTYPE_EMPTY_ARRAY.

[String/UUID change made/needed]: none

Comment 11

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8637323 [details]
MozReview Request: Bug 1186209 - check for VTYPE_EMPTY_ARRAY in enumerateDevices + test.

Simple fix, has an automated test, let's uplift to Aurora.

Comment 12

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Mark, can you please verify the fix on a nightly build from 7/24 or later? Thanks!

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Needs rebasing for Aurora uplift.

Comment 14

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: check for VTYPE_EMPTY_ARRAY in enumerateDevices + test (aurora) r=jesup

Rebased on aurora. Carrying forward r=jesup.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/81288e78a1d4

Comment 16

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: fix aurora test (turn off fake devices if loopback devices are present)

Fixes linux oranges https://treeherder.mozilla.org/#/jobs?repo=mozilla-aurora&revision=15b3cf5a2831

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d0d33fb9835e

Comment 18

[Mark Banner (:standard8)]

I've just retested this on latest Windows versions of nightly & aurora and it now works fine.

Thanks Jib.