118621 - http://foo/bar/ default save name should be bar.html

Status: RESOLVED FIXED

(Core Graveyard :: File Handling, defect, P2)

Description

[Jeremy M. Dolan]

When saving a page, frame, link, etc, where there is no file name, but a
directory name, as in http://foo/bar/, the default file name for save should be
bar.html.

We already do this for locations of the form http://foo/... saving to foo.html.

This is split off from bug 115176.

Comment 1

[Boris Zbarsky [:bzbarsky]]

*** Bug 120321 has been marked as a duplicate of this bug. ***

Comment 2

[Boris Zbarsky [:bzbarsky]]

*** Bug 131412 has been marked as a duplicate of this bug. ***

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

So, it looks like we currently use the title of the page (I tested File|Save
page as). Is this bug for making it use the directoryname + .html in all cases?
Or only if there is no <title> (no idea what we do in this case)?

Or is this not about File|Save page as, but shift+link click, or another save
feature?

Comment 4

[Boris Zbarsky [:bzbarsky]]

Yeah, this is for the case when there is no <title> (which is also the
"shift-click" case, so life is easy ;) ).

What we do right now is
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/xpfe/communicator/resources/content/contentAreaUtils.js&rev=1.74&mark=737,743,770,776,%20781,787,792#734

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

What about http://foo/bar/blah/
Should blah.html be used, or bar_blah.html?
(the second one is easier to implement, and I have a patch for that actually)

Comment 6

[Boris Zbarsky [:bzbarsky]]

I think the proposal was that that would become blah.html

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

-> me

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 9

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 126721 [details] [diff] [review]
patch

actually this is not ideal, I have a slightly better patch (use .path instead
of .spec)

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch v2

Comment 11

[jag (Peter Annema)]

Comment on attachment 126722 [details] [diff] [review]
patch v2

You can get the result of |re.test(aDocumentURI.path)| by testing
|aDocumentURI.path.match(re)| against null, if you must.

Comment 12

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 126722 [details] [diff] [review]
patch v2

ok, I'll attach a new patch that nulltests .match

Comment 13

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch v2

Comment 14

[jag (Peter Annema)]

Comment on attachment 127264 [details] [diff] [review]
patch v2

r=jag if you inline the |re|.

Comment 15

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in resources/content/contentAreaUtils.js;
/cvsroot/mozilla/xpfe/communicator/resources/content/contentAreaUtils.js,v  <--
 contentAreaUtils.js
new revision: 1.83; previous revision: 1.82
done

Comment 16

[Jeremy M. Dolan]

This does not seem to be functioning properly. For URLs that end in "/directory/",
Firebird is using the <title> as the default name. This is highly undesirable to me.

Tested at: http://www.google.com/options/

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5a) Gecko/20030715 Mozilla Firebird/0.6

Comment 17

[Christian :Biesinger (don't email me, ping me on IRC)]

this has always been a mozilla bug, so please test in mozilla. testing this in
firebird is worthless as I'm quite sure they forked this file. thanks.

Comment 18

[Jeremy M. Dolan]

Filed Bug 212904 for firebird as advised by #firebird. Thanks for finally doing
99% of the work here, Christian. It was a pet peeve.

Comment 19

[[e-mail]]

Comment on attachment 126722 [details] [diff] [review]
patch v2

>+  var re = /\/([^\/]+)\/$/;
>+  if (re.test(aDocumentURI.path)) {
>+    var path = aDocumentURI.path.match(re);
>+    if (path.length > 1)
>+      return validateFileName(path[1]);
>+  }
Actually the way to go here is
if (/\/([^\/]+)\/$/.test(aDocumentURI.path))
  return validateFileName(Regexp.$1);