1186210 - Delete expired Necko histograms & accumulation code

Status: RESOLVED FIXED

(Core :: Networking, task, P3)

Description

[Vladan Djeric (:vladan)]

A lot of Necko histograms have expired and need to be removed from the codebase along with their accumulation code.

Full list of expired histograms:
https://groups.google.com/forum/#!topic/mozilla.dev.telemetry-alerts/Uw9svhVTrXk

There are about a dozen expired Necko histograms in the list above:

UDP_SOCKET_PARALLEL_CLOSE_COUNT
DISK_CACHE_
LOCALDOMSTORAGE_
SESSIONDOMSTORAGE_

Comment 1

[Jason Duell]

Honza/Michal: the majority of these probes are from the cache/localstorage.  Can you verify that we're fine removing them all?

Comment 2

[Honza Bambas (:mayhemer)]

Michal should decide on these:
NETWORK_CACHE_FS_TYPE
NETWORK_CACHE_SIZE_FULL_FAT

On these I vote to remove:
CACHE_SERVICE_LOCK*
NETWORK_DISK_CACHE_*
DISK_CACHE_*
LOCALDOMSTORAGE_* since our localStorage impl is far best of all browsers and I don't want to invest time in more optimizations any time sooner.  we can introduce the probes again if needed ; I'll do the removal on these
SESSIONDOMSTORAGE_*

Comment 3

[Michal Novotny [:michal]]

(In reply to Honza Bambas (not reviewing) (:mayhemer) from comment #2)
> Michal should decide on these:
> NETWORK_CACHE_FS_TYPE
> NETWORK_CACHE_SIZE_FULL_FAT

These can be removed. The amount of data we've collected is enough.

Comment 4

[Charlotte Wilson [:cswilson252]]

Attachment: Bug 1186210 - Delete expired Necko and LocalStorage histograms r=#necko-reviewers,toolkit-telemetry-reviewers,dom-storage-reviewers!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c65f78036bc1
https://hg.mozilla.org/integration/autoland/rev/bceec188eaa6
Delete remaining expired Necko histograms r=necko-reviewers,toolkit-telemetry-reviewers,kershaw,dom-storage-reviewers,jesup

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7fc83e3f7e11
https://hg.mozilla.org/integration/autoland/rev/8f5b6abe842f
Revert "Bug 1186210 - Delete remaining expired Necko histograms r=necko-reviewers,toolkit-telemetry-reviewers,kershaw,dom-storage-reviewers,jesup" for causing bustages @ LocalStorageCache.cpp

Comment 7

[Norisz Fay [:noriszfay]]

Backed out for causing bustages @ LocalStorageCache.cpp

Backout link

Push with failures

Failure log

Comment 8

[Charlotte Wilson [:cswilson252]]

Added back base metrics.yaml for header compatibility.

Comment 9

[Charlotte Wilson [:cswilson252]]

breakage is caused by https://searchfox.org/firefox-main/source/dom/storage/LocalStorageCache.cpp#238

Comment 10

[Charlotte Wilson [:cswilson252]]

Wondering if any of these histograms are still needed/used, as many are set to expires: never.

Comment 11

[Valentin Gosu [:valentin] (he/him)]

I can only speak for the networking one:
https://glam.telemetry.mozilla.org/fog/probe/network_disk_cache_shutdown_v2/explore?visiblePercentiles=%5B99.9%2C99%2C95%2C75%2C50%2C25%2C5%5D

We don't check it often. It's mostly there to track whether the Cache thread shuts down in reasonable time.
It might still be useful, but given that we haven't looked at it in a while, and there are no current shutdown hang issues, I'm OK with removing it.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/245f8ca52ddd
https://hg.mozilla.org/integration/autoland/rev/5f9814a3049e
Delete expired Necko and LocalStorage histograms r=necko-reviewers,toolkit-telemetry-reviewers,kershaw,dom-storage-reviewers,jesup,janv

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9cf0cdca48f4
https://hg.mozilla.org/integration/autoland/rev/0e7780173c75
Revert "Bug 1186210 - Delete expired Necko and LocalStorage histograms r=necko-reviewers,toolkit-telemetry-reviewers,kershaw,dom-storage-reviewers,jesup,janv" for causing build bustages @LocalStorageCache.

Comment 14

[agoloman]

Backed out for causing build bustages @LocalStorageCache.

• Backout link
• Push with failures
• Failure Log

Comment 15

[Charlotte Wilson [:cswilson252]]

Pushed fix (header removal) up to Phabricator.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6974eb7ab8ce
https://hg.mozilla.org/integration/autoland/rev/37d35c3e2afa
Delete expired Necko and LocalStorage histograms r=necko-reviewers,toolkit-telemetry-reviewers,kershaw,dom-storage-reviewers,jesup,janv

Comment 17

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/37d35c3e2afa