Closed Bug 1186224 Opened 4 years ago Closed 4 years ago

Skip timeout/hang-prone layout mochitests on B2G debug

Categories

(Core :: Layout, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: RyanVM, Assigned: RyanVM)

References

Details

At least test_extra_inherit_initial.html and test_property_syntax_errors.html need to be disabled to avoid frequent timeouts or harness hangs due to skyrocketing memory use.
And test_logical_properties.html
See Also: → 1186219
Summary: Skip failure-prone layout mochitests on B2G debug → Skip timeout/hang-prone layout mochitests on B2G debug
I think we may just need to periodically yield to allow for GC. Otherwise, the garbage that we create as we process each property just piles up.  (This isn't necessarily bad; we do probably save some time by plowing through all the properties & doing a single mega-GC at the end of the test. But if we're hitting memory limits on resourse-constrained test platforms, then we should allow for periodic GC's.)

I've got some patches locally which restructure test_extra_inherit_initial.html to allow for this. I'm running them through Try and I'll probably end up posting them here.
Summary: Skip timeout/hang-prone layout mochitests on B2G debug → Skip or improve timeout/hang-prone layout mochitests on B2G debug
Er, I'll probably do that over on bug 1168222. (Got confused by a mis-pasted bug number over on bug 1186219.)
The approach in bug 1168222 is definitely preferable, but the Try run is confirmed green otherwise at least :)
Sadly, my strategy in bug 1168222 is not as effective as I'd hoped. [1]

So, let's go ahead with RyanVM's plan of disabling these tests on b2g, in the interests of un-hiding this test job, and then we can play around with fixing+re-enabling the individual tests later on.


[1] e.g. yielding after each CSS property (which I was hoping would be super effective, though maybe a slight slowdown), 7/8 of my B2G ICS Emulator debug M25 runs still end up with "timed out after 1000 seconds of no output" in test_extra_inherit_initial.html:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d13881fecce5&exclusion_profile=false
Summary: Skip or improve timeout/hang-prone layout mochitests on B2G debug → Skip timeout/hang-prone layout mochitests on B2G debug
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #2)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=c9938f2f46bc

r=me on the patch that you included for this bug in this Try run -- disabling test_extra_inherit_initial.html, test_property_syntax_errors.html, test_logical_properties.html for b2g (gonk) + debug.
(Though maybe tweak the commit message to replace "failure-prone" with something more accurate -- harness-timeout-prone, perhaps?)
https://hg.mozilla.org/mozilla-central/rev/1fea01a79521
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
See Also: → 1168222
You need to log in before you can comment on or make changes to this bug.