1186224 - Skip timeout/hang-prone layout mochitests on B2G debug

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

At least test_extra_inherit_initial.html and test_property_syntax_errors.html need to be disabled to avoid frequent timeouts or harness hangs due to skyrocketing memory use.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

And test_logical_properties.html

Comment 2

[Ryan VanderMeulen [:RyanVM]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c9938f2f46bc

Comment 3

[Daniel Holbert [:dholbert]]

I think we may just need to periodically yield to allow for GC. Otherwise, the garbage that we create as we process each property just piles up.  (This isn't necessarily bad; we do probably save some time by plowing through all the properties & doing a single mega-GC at the end of the test. But if we're hitting memory limits on resourse-constrained test platforms, then we should allow for periodic GC's.)

I've got some patches locally which restructure test_extra_inherit_initial.html to allow for this. I'm running them through Try and I'll probably end up posting them here.

Comment 4

[Daniel Holbert [:dholbert]]

Er, I'll probably do that over on bug 1168222. (Got confused by a mis-pasted bug number over on bug 1186219.)

Comment 5

[Ryan VanderMeulen [:RyanVM]]

The approach in bug 1168222 is definitely preferable, but the Try run is confirmed green otherwise at least :)

Comment 6

[Daniel Holbert [:dholbert]]

Sadly, my strategy in bug 1168222 is not as effective as I'd hoped. [1]

So, let's go ahead with RyanVM's plan of disabling these tests on b2g, in the interests of un-hiding this test job, and then we can play around with fixing+re-enabling the individual tests later on.


[1] e.g. yielding after each CSS property (which I was hoping would be super effective, though maybe a slight slowdown), 7/8 of my B2G ICS Emulator debug M25 runs still end up with "timed out after 1000 seconds of no output" in test_extra_inherit_initial.html:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d13881fecce5&exclusion_profile=false

Comment 7

[Daniel Holbert [:dholbert]]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #2)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=c9938f2f46bc

r=me on the patch that you included for this bug in this Try run -- disabling test_extra_inherit_initial.html, test_property_syntax_errors.html, test_logical_properties.html for b2g (gonk) + debug.

Comment 8

[Daniel Holbert [:dholbert]]

(Though maybe tweak the commit message to replace "failure-prone" with something more accurate -- harness-timeout-prone, perhaps?)

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1fea01a79521

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1fea01a79521