1186235 - mozharness should set VIRTUALENV_EXISTS to avoid creating a duplicate python venv

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[Aus Lacroix [:aus]]

The npm-cache-get step in mozharness doesn't set VIRTUALENV_EXISTS before installing the node modules which sets up two different venv's which is certainly not a good thing. I found this while debugging bug 1174901 and it's certainly possible it's causing issues.

Patch for this will be up soon.

Comment 1

[Aus Lacroix [:aus]]

Attachment: Patch - v1 - Set VIRTUALENV_EXISTS when calling taskcluster-npm-cache-get

Pretty straightforward. We need to do this because the python virtual environment is already set-up and taskcluster-npm-cache-get needs to call npm install.

Comment 2

[Aus Lacroix [:aus]]

Commit (default): https://hg.mozilla.org/build/mozharness/rev/ecbd95222e8a

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/48348bfad309

Comment 4

[Aus Lacroix [:aus]]

Commit (b2g-inbound): https://hg.mozilla.org/integration/b2g-inbound/rev/48348bfad309

Revision bumped to ecbd95222e8a.

Marking fixed.

Comment 5

[Release Engineering SlaveAPI Service]

mozharness production tag moved to: https://hg.mozilla.org/build/mozharness/rev/production

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/78e77e3d2b1f

Comment 7

[Jordan Lund (:jlund)]

mozharness production tag moved to: https://hg.mozilla.org/build/mozharness/rev/production

Comment 8

[Jordan Lund (:jlund)]

mozharness production tag moved to: https://hg.mozilla.org/build/mozharness/rev/production

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/78e77e3d2b1f