Closed Bug 1186235 Opened 5 years ago Closed 5 years ago

mozharness should set VIRTUALENV_EXISTS to avoid creating a duplicate python venv

Categories

(Release Engineering :: Applications: MozharnessCore, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: aus, Assigned: aus)

References

Details

Attachments

(1 file)

The npm-cache-get step in mozharness doesn't set VIRTUALENV_EXISTS before installing the node modules which sets up two different venv's which is certainly not a good thing. I found this while debugging bug 1174901 and it's certainly possible it's causing issues.

Patch for this will be up soon.
Pretty straightforward. We need to do this because the python virtual environment is already set-up and taskcluster-npm-cache-get needs to call npm install.
Attachment #8636866 - Flags: review?(jgriffin)
Attachment #8636866 - Flags: review?(jgriffin) → review+
Commit (b2g-inbound): https://hg.mozilla.org/integration/b2g-inbound/rev/48348bfad309

Revision bumped to ecbd95222e8a.

Marking fixed.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Blocks: 1174901
You need to log in before you can comment on or make changes to this bug.